1953479 - New sap.counts probe needs to indicate when search urls are overriden by partner codes

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

After landing the new sap.counts event in bug 1938929, I realised that I'd missed taking account of the existing SEARCH_COUNTS reporting that distinguishes counts that come from a search engine that is overridden by an add-on.

We need to figure out the best way of adding this information to the new event.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1953479 - Add a SearchUITestUtils helper with a function for checking search SAP counts. r?scunnane!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1953479 - In the sap.counts event probe, account for search engines being overridden by allowed third parties. r?scunnane!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1953479 - Update TypeScript definitions for the latest changes. r?scunnane!

This includes the nsISearchEngine addition.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/026b35d9c0ee
Add a SearchUITestUtils helper with a function for checking search SAP counts. r=scunnane
https://hg.mozilla.org/integration/autoland/rev/daa384b77c14
In the sap.counts event probe, account for search engines being overridden by allowed third parties. r=scunnane
https://hg.mozilla.org/integration/autoland/rev/ce777855bcb7
Update TypeScript definitions for the latest changes. r=scunnane

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/026b35d9c0ee
https://hg.mozilla.org/mozilla-central/rev/daa384b77c14
https://hg.mozilla.org/mozilla-central/rev/ce777855bcb7