1953516 - Network monitor is not fetching timings for totalTime = 0 requests

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Julian Descottes [:jdescottes]]

This seems to be the root cause of several intermittent failures such as Bug 1767658.

Our netmonitor test helpers strongly rely on waiting for "eventTimings" to mark the end of the request.
However this data is only requested on demand by the Waterfall component (which already sounds fragile).

And this component will also incorrectly skip requesting eventTimings if the totalTime of the request is 0ms:

https://searchfox.org/mozilla-central/rev/b0e8e4ceb46cb3339cdcb90310fcc161ef4b9e3e/devtools/client/netmonitor/src/components/request-list/RequestListColumnWaterfall.js#60-63

if (nextProps.isVisible && nextProps.item.totalTime) {
  const { connector, item } = nextProps;
  fetchNetworkUpdatePacket(connector.requestData, item, ["eventTimings"]);
}

Instead of nextProps.item.totalTime we should check if typeof nextProps.item.totalTime == "number".

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1953516 - [devtools] Fetch event timings for all requests which have a valid totalTime

For very fast requests with a 0s totalTime we never request event timings,
which can hang browser mochitests which depend on this to consider requests as done.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71dedeeef0ec
[devtools] Fetch event timings for all requests which have a valid totalTime r=devtools-reviewers,ochameau

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/71dedeeef0ec