1953573 - Modify lazy.URILoadingHelper.getTargetWindow callers with "skipPopups: true" to also have "skipTaskbarTabs: true"

Status: NEW

(Firefox :: Shell Integration, task, P3)

Description

[Eric Chen]

When lazy.URILoadingHelper.getTargetWindow is called with skipPopups: true (https://searchfox.org/mozilla-central/search?path=&q=skipPopups%3A%20true%2C), we should also set skipTaskbarTabs: true, since popups and taskbartabs are inherently very similar. They both are single tab browsers and have a readonly search bar.

Comment 1

[Eric Chen]

I think we just need to modify this caller: https://searchfox.org/mozilla-central/rev/b0e8e4ceb46cb3339cdcb90310fcc161ef4b9e3e/browser/components/search/SearchUIUtils.sys.mjs#226-228

The caller in URILoadingHelper.sys.mjs will be modified in https://phabricator.services.mozilla.com/D240907
The caller in CustomizeMode.sys.mjs will be addressed in Bug 1953588

Comment 2

[Eric Chen]

The case in https://searchfox.org/mozilla-central/rev/b0e8e4ceb46cb3339cdcb90310fcc161ef4b9e3e/browser/components/search/SearchUIUtils.sys.mjs#226-228 was resolved by Bug 1953182