1953581 - ghost buttons don't inherit the color properly

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: screenshot with the setup on the blocked bug

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1953581 - Make moz-button really respect --button-text-color-ghost. r=#theme

Without this change, consider a ghost button like:

<div style="color: white; background: black;">
<moz-button type="ghost">Foo</moz-button>

The <button> inside the shadow tree will get color:
var(--button-text-color), and then .button-background would get
var(--button-text-color-ghost), which will inherit --button-text-color
rather than the color you want (white in this case).

Instead, inherit the color through the button by default.

Depends on D241274

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1953581 - Make ghost buttons not change color on hover/active. r=#theme

Much like D237760.

Depends on D241275

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94ae18cad0f6
Make moz-button really respect --button-text-color-ghost. r=desktop-theme-reviewers,reusable-components-reviewers,dao,tgiles
https://hg.mozilla.org/integration/autoland/rev/d2d7e7eb2f94
Make ghost buttons not change color on hover/active. r=desktop-theme-reviewers,reusable-components-reviewers,dao,tgiles

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/94ae18cad0f6
https://hg.mozilla.org/mozilla-central/rev/d2d7e7eb2f94