Closed Bug 1953851 Opened 1 month ago Closed 21 days ago

URLs to MDN HTTP reference docs need to be updated ('Show MDN Docs' tooltip)

Categories

(DevTools :: Netmonitor, task)

task

Tracking

(firefox136 wontfix, firefox139 fixed)

RESOLVED FIXED
139 Branch
Tracking Status
firefox136 --- wontfix
firefox139 --- fixed

People

(Reporter: brismith, Assigned: bomsy)

References

()

Details

Attachments

(1 file)

The MDN HTTP reference docs will have a new scheme soon. The following sections have a Reference/ prefix now:

  • Headers
  • Methods
  • Statuses

So, the new scheme looks like:

- Web/HTTP/Headers/
+ Web/HTTP/Reference/Headers/

- Web/HTTP/Status/
+ Web/HTTP/Reference/Status/

- Web/HTTP/Methods/
+ Web/HTTP/Reference/Methods/

Redirects are in place on MDN for all existing URLs, but we should update the URL prefix used in netmonitor to avoid hitting 301s.

See https://searchfox.org/mozilla-release/rev/02a9c1b3286ae3b7ca322b47e55fddb83d4e371c/devtools/client/netmonitor/src/utils/doc-utils.js#126-134

For example;

function getHeadersURL(header) {
  const lowerCaseHeader = header.toLowerCase();
  const idx = SUPPORTED_HEADERS.findIndex(
    item => item.toLowerCase() === lowerCaseHeader
  );
  return idx > -1
    ? `${MDN_URL}Web/HTTP/Headers/${SUPPORTED_HEADERS[idx] + getGAParams()}`
    : null;
}

Guides are also updated, but I don't see any places in netmonitor affected by this.

Thanks for filing Brian,

Guides are also updated, but I don't see any places in netmonitor affected by this.

Just confirming we have links to guides errors , i see Web/HTTP/CORS/Errors/ has changed to Web/HTTP/Guides/CORS/Errors/ .. is this correct?

Flags: needinfo?(brismith)

Hi Hubert. Yes that's correct, thanks for changing it. I took a look at your patch and this makes sense.

For the record, this is the from -> to mapping for redirects for those docs.

Flags: needinfo?(brismith)
Assignee: nobody → hmanilla
Attachment #9471993 - Attachment description: WIP: Bug 1953851 - [devtools] Update MDN links → Bug 1953851 - [devtools] Update the MDN links in devtools r=#devtools
Status: NEW → ASSIGNED
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d11f76b4c4d [devtools] Update the MDN links in devtools r=devtools-reviewers,nchevobbe

Backed out for causing devtools failures in browser_webconsole_cors_errors.js.

Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f123a8f22b50 [devtools] Update the MDN links in devtools r=devtools-reviewers,nchevobbe

(In reply to Brian Thomas Smith [bsmth] from comment #3)

Hi Hubert. Yes that's correct, thanks for changing it. I took a look at your patch and this makes sense.

For the record, this is the from -> to mapping for redirects for those docs.

Thanks brian!

Flags: needinfo?(hmanilla)

Backed out for causing devtools failures in browser_webconsole_warning_group_cookies.js.

Flags: needinfo?(hmanilla)
Attachment #9471993 - Attachment description: Bug 1953851 - [devtools] Update the MDN links in devtools r=#devtools → Bug 1953851 - [devtools] Update the MDN links r=#devtools
Flags: needinfo?(hmanilla)
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/376442637e13 [devtools] Update the MDN links r=devtools-reviewers,nchevobbe,cookie-reviewers,valentin,fluent-reviewers,zeid,anti-tracking-reviewers,translations-reviewers,android-reviewers,flod,bvandersloot,jonalmeida,tthibaud
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51582 for changes under testing/web-platform/tests
Upstream PR was closed without merging
Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48b3c1a705d4 [devtools] Update the MDN links r=devtools-reviewers,nchevobbe,cookie-reviewers,valentin,fluent-reviewers,shtrom,zeid,anti-tracking-reviewers,translations-reviewers,android-reviewers,flod,bvandersloot,jonalmeida,tthibaud
Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
Upstream PR merged by moz-wptsync-bot
Flags: needinfo?(hmanilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: