Closed
Bug 1953857
Opened 1 months ago
Closed 24 days ago
Add support for picker style tiles in the AboutWelcome MultiSelect component
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
People
(Reporter: mviar, Assigned: jprickett)
References
(Blocks 1 open bug, )
Details
Attachments
(2 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
In bug 1910633 we added support for a single select "picker" style interface where users make their select by clicking tiles that can be configured with text and images. For this bug, we'll add support for a similar UI in the MultiSelect component (see Figma designs, final approval of designs pending).
Assignee | ||
Updated•1 month ago
|
Iteration: 138.1 - Mar 3 - Mar 14 → 138.2 - Mar 17 - Mar 28
Reporter | ||
Updated•1 month ago
|
Points: --- → 3
Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
Attachment #9475139 -
Attachment description: WIP: Bug 1953857 - Add styles to support picker design in multiselect → Bug 1953857 - Add styles to support picker design in multiselect r?#omc-reviewers
Pushed by jprickett@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6ee48e51f4e
Add styles to support picker design in multiselect r=omc-reviewers,mviar
Comment 3•24 days ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 24 days ago
status-firefox139:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 139 Branch
Assignee | ||
Comment 4•20 days ago
|
||
This patch adds functionality to the multiselect component to allow for a "picker" design. The picker design is enabled by adding the multiSelectDesign
property with a value of picker
to a tile object of type multiselect
.
Original Revision: https://phabricator.services.mozilla.com/D243350
Updated•20 days ago
|
Attachment #9477531 -
Flags: approval-mozilla-beta?
Comment 5•20 days ago
|
||
beta Uplift Approval Request
- User impact if declined: N/A - Will not be able to run an experiment with these new styles in this release.
- Code covered by automated testing: yes
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: Test steps are in the original patch
- Risk associated with taking this patch: Low
- Explanation of risk level: The patch implements style changes that are behind a conditional that can be passed in with a messaging surface message
- String changes made/needed: None
- Is Android affected?: no
Flags: qe-verify+
Updated•19 days ago
|
QA Whiteboard: [qa-triaged]
Updated•19 days ago
|
Attachment #9477531 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•19 days ago
|
status-firefox138:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•