Closed
Bug 1953865
Opened 2 months ago
Closed 1 month ago
[Downloads v2] [Refactor] Move icon evaluation logic to the FileItem (UIModel) instead of doing in compose
Categories
(Firefox for Android :: Downloads, task, P2)
Tracking
()
RESOLVED
FIXED
138 Branch
| Tracking | Status | |
|---|---|---|
| firefox138 | --- | fixed |
People
(Reporter: rsainani, Assigned: npoon)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [group4])
Attachments
(1 file)
Currently, FileItem.getIcon() is called in compose UI. As a result this is evaluated everytime composition occurs. This data is depenent on the FIleItem which is a data class. So this can be moved as a derived property of the data class so it's evaluated once per object creation.
|
||
Updated•2 months ago
|
|
Assignee | |
Updated•1 month ago
|
Assignee: nobody → npoon
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•1 month ago
|
||
Pushed by npoon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/670dc4adac66
Move Downloads icon evaluation logic from composable into FileItem r=android-reviewers,rsainani
|
||
Comment 3•1 month ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox138:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•