1953920 - [Win] USB dropdown is not dismissed when clicking on it to close it

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Found in

• Firefox Nightly 138.0a1;

Affected versions

• Firefox Nightly 138.0a1;
• Firefox 137 beta 5;

Affected platforms

• Windows 10;

Unaffected platforms

• Ubuntu 24;
• macOS 15;

Steps to reproduce

1. Open a new tab and click on the Unified Search Button to open the dropdown.
2. Click on the Unified Search Button again to close the dropdown.

Expected result

• USB dropdown is closed, USB button returns to default state.

Actual result

• USB dropdown flickers and remains open. No errors are shown in the browser console.
• This happens ~ 9 out of 10 tries.

Regression range

• last good: 2025-02-12;
• first bad: 2025-02-13;
• pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1c695e81404d9c569838b59ddd3a5ba77df87f03&tochange=a3ddc7278467e7fdc06ba96e92ff883aba52b208
• regressed by: bug 1934410

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1934410, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1953920: Avoid capturing event on Unified Search Button when hiding the popup by mouse

Depends on D241542

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b74e1a3e693
Avoid capturing event on Unified Search Button when hiding the popup by mouse r=daleharvey

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing searchModeSwitcher related failures

Backout link

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f2b5baa686bd
Avoid capturing event on Unified Search Button when hiding the popup by mouse r=daleharvey

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f2b5baa686bd

Comment 7

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9472205 [details]
Bug 1953920: Avoid capturing event on Unified Search Button when hiding the popup by mouse

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: The Unified Search engines popup will be flickering and may remain as is, if clicking the Unified Search Button again while showing the popup.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fixing only the flickering.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/722f65645f28

Comment 9

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2025-03-13 Firefox Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 138.0a1 and Firefox 137.0 on Windows 10.