1953979 - Explicitly set `layout.scroll.disable-pixel-alignment` to true at the top directory of web platform tests.

Status: RESOLVED FIXED

(Core :: Panning and Zooming, task, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

With disabling pixel alignments there are a bunch of unexpected pass web platform tests. That's a good outcomes of disabling pixel alignments. But if we had to revert the pref change for some reasons, e.g. unexpected regressions or some such, we also need to revert web platform annotation changes too. To avoid it, we are going to set the pref layout.scroll.disable-pixel-alignment at the top of web platform test directory so that the unexpected pass web platform tests keep passing regardless of the default pref value.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1953979 - Explicitly set `layout.scroll.disable-pixel-alignment` to true at the top directory of web platform tests. r?botond

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1953979 - Explicitly set `layout.scroll.disable-pixel-alignment` to true at the top directory of web platform tests. r?botond

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d49792d2b29
Explicitly set `layout.scroll.disable-pixel-alignment` to true at the top directory of web platform tests. r=botond

Comment 4

[agoloman]

Backed out for causing wpt failures @overscroll-behavior-root.html.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Filed bug 1954403 to fix the failure. The failure message is;

overscroll-behavior in root works - promise_test: Unhandled rejection with value: "error: Action action_sequence failed: Expected \"y\" to be an Integer, got [object Number] 772.4000244140625\nstacktrace:\n\tRemoteError@chrome://remote/content/shared/RemoteError.sys.mjs:8:8\n\tWebDriverError@chrome://remote/content/shared/webdriver/Errors.sys.mjs:199:5\n\tInvali

I can see this error locally on my Linux box with --setpref="layout.css.devPixelsPerPx=1.7" --headless options.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/880933d33ee0
Explicitly set `layout.scroll.disable-pixel-alignment` to true at the top directory of web platform tests. r=botond

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/880933d33ee0

Comment 8

[agoloman]

Attachment: Bug 1953979 - remove expectations for animation related subtests because they're passing now. r=hiro

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b14b6fffef57
remove expectations for animation related subtests because they're passing now. r=hiro DONTBUILD

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b14b6fffef57

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)