1954077 - Crash when navigating to page with toolbar renderStyle set to ColoredUrl

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Michel Le Bihan]

Steps to reproduce

1. Change the toolbar URL render style to ColoredUrl:

--- a/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt
+++ b/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/components/toolbar/ToolbarIntegration.kt
@@ -141,7 +141,7 @@ class DefaultToolbarIntegration(
     interactor = interactor,
     customTabId = customTabId,
     isPrivate = isPrivate,
-    renderStyle = ToolbarFeature.RenderStyle.UncoloredUrl,
+    renderStyle = ToolbarFeature.RenderStyle.ColoredUrl,
 ) {
 
     @VisibleForTesting

2. Navigate to a page

Expected behavior

The app does not crash

Actual behavior

The app crashes

Any additional information?

03-14 11:46:16.745  3319  3319 E AndroidRuntime: FATAL EXCEPTION: main
03-14 11:46:16.745  3319  3319 E AndroidRuntime: Process: org.mozilla.fenix.debug, PID: 3319
03-14 11:46:16.745  3319  3319 E AndroidRuntime: java.lang.ClassCastException: android.text.SpannableStringBuilder cannot be cast to java.lang.String
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at mozilla.components.browser.toolbar.BrowserToolbar.setUrl(BrowserToolbar.kt:120)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at mozilla.components.feature.toolbar.internal.URLRenderer.updateUrl$feature_toolbar_debug(URLRenderer.kt:73)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at mozilla.components.feature.toolbar.internal.URLRenderer$updateUrl$1.invokeSuspend(Unknown Source:15)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:959)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:100)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at android.os.Looper.loopOnce(Looper.java:232)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:317)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8751)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:892)
03-14 11:46:16.745  3319  3319 E AndroidRuntime: 	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@2be6aa1, Dispatchers.Main]

Comment 1

[Michel Le Bihan]

Attachment: Bug 1954077 - Add trimmed method to CharSequence in ktx component. r=tthibaud

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93b03add42cc
Add trimmed method to CharSequence in ktx component. r=android-reviewers,tthibaud

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/93b03add42cc