1954140 - StyleAdjuster adjust_for_prohibited_display_contents should account for element-backed pseudo elements

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Luke Warlow]

This is needed for ::details-content support.

Comment 1

[Luke Warlow]

I think I know what needs to happen here but the bit about ::before and ::after makes me not 100% sure.

Comment 2

[Daniel Holbert [:dholbert]]

Hi Luke - thanks for the work on this details stuff!

For planning purposes (and no pressure, just checking): were you planning to take this one and/or bug 1954142?

Comment 3

[Luke Warlow]

Yeah I plan to take at least this one and the element_backed psuedo parsing change one on. The other one I'll have to double check but I think I understand it.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

(In reply to Luke Warlow from comment #1)

I think I know what needs to happen here but the bit about ::before and ::after makes me not 100% sure.

Just bailing out for element-backed pseudos seems fine. The comment is saying basically that ::before and ::after should support display: contents, but that's a larger, more annoying change, see bug 1418138.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1954140 - Don't forbid display: contents on element-backed pseudo-elements. r=#style,lukewarlow

This will be tested after a few other related changes land by tests like
testing/web-platform/tests/html/rendering/the-details-element/details-blockification.html

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a7f3fc99d0b
Don't forbid display: contents on element-backed pseudo-elements. r=lukewarlow

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5a7f3fc99d0b