Closed Bug 1954163 Opened 2 months ago Closed 1 month ago

Hitting Ctrl on the keyboard while trying to group 2 tabs by Drag and Drop will break the UI

Categories

(Firefox :: Tabbed Browser, defect, P1)

Desktop
Unspecified
defect
Points:
2

Tracking

()

VERIFIED FIXED
138 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox136 --- unaffected
firefox137 --- unaffected
firefox138 --- verified

People

(Reporter: rdoghi, Assigned: dao)

References

(Blocks 3 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-tabgrps-dnd])

Attachments

(2 files)

Attached video 2025-03-14_17h20_31.mp4

Found in

  • Nightly 138.0a1 (2025-03-14)

Affected versions

  • Nightly 138.0a1 (2025-03-14)

Affected platforms

  • All

Steps to reproduce

  1. Have a few tabs open.
  2. Drag a Tab on top of another in order to create a Tab group.
  3. Hold the Ctrl key on the keyboard when trying to drop the tab.
  4. Select another tab.

Expected result

  • The Tabs should location should adjust and the Tab group should be created.
    The UI for the tab strip should adapt to the Tabs movement.

Actual result

  • The Tabs remain on top of eachother without creating the group.

Regression range
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=68d1a44fdef33f1256471aa630bebf080599dd4e&tochange=fdc1c87c70f2a9e1eea62291478ba1e3a4a5906f

Flags: needinfo?(dao+bmo)

Hi @Dao, can you take a look at this ? Im not sure which of the 3 issues caused this one.

Likely caused by bug 1953193 I'd say.

Blocks: 1907101
Severity: -- → S2
Points: --- → 1
Flags: needinfo?(dao+bmo)
Keywords: regression
Priority: -- → P1
Regressed by: 1953193
Whiteboard: [fidefe-tabgrps-dnd]
Points: 1 → 2
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #9472209 - Attachment description: Bug 1954163 - Properly enter and exit moving tabs mode when holding or releasing Ctrl key. r=jswinarton,dwalker,sthompson → Bug 1954163 - Properly enter and exit moving tab mode when holding or releasing Ctrl key. r=jswinarton,dwalker,sthompson
Summary: Hitting Ctrl on the keyboard while trying to group 2 tabs by Drag an Drop will break the UI → Hitting Ctrl on the keyboard while trying to group 2 tabs by Drag and Drop will break the UI
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/168ba991246a Properly enter and exit moving tab mode when holding or releasing Ctrl key. r=jswinarton,tabbrowser-reviewers
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch

Verified as fixed in our latest Nightly 138.0a1 (2025-03-20)

Status: RESOLVED → VERIFIED
Blocks: 1955112

I have Reverified the Fix in our latest Beta 138.0b5 (64-bit) 20250409020608

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: