1954168 - orientation.unlock should throws an exception per common safety check

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Makoto Kato [:m_kato]]

Per https://w3c.github.io/screen-orientation/#unlock-method

Comment 1

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/jobs?repo=try&revision=f6b8a8954232240968179defa030cf409c1c04da

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1954168 - Throw an exception when calling unlock() is failed by common safety checks. r=#dom-core!

orientation.unlock() has to process the common safety checks [*1], then
it throws an exception by common safety checks. But since old spec doesn't
throw an exception, we don't throw it by unlock() now.

So we should throw it even if calling unlock().

lock-sandboxed-iframe.html has a bug that it doesn't consider
whether unlock throws an exception. So we have to fix it to implement
the common safety check for unlock().

On macOS's native fullscreen implementation, fullscreen transition is
asynchronous, so even if the promise of requestFullscreen is resolved,
the window isn't still activated yet, visibility state may be still hidden.
(This will be visible state soon). So I would like to disable native
fullscreen on screen-orientation tests for this situation.

*1 https://w3c.github.io/screen-orientation/#unlock-method

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1487cbbfa7eb
Throw an exception when calling unlock() is failed by common safety checks. r=dom-core,edgar

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/51514 for changes under testing/web-platform/tests

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1487cbbfa7eb

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot