1954682 - On Thunderbird startup: JavaScript error: resource://devtools/client/performance-new/popup/menu-button.sys.mjs, line 17: Error: Failed to load resource:///modules/CustomizableWidgets.sys.mjs

Status: RESOLVED INVALID

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Magnus Melin [:mkmelin]]

After bug 1950884 every time I start Thunderbird in the native console I see
JavaScript error: resource://devtools/client/performance-new/popup/menu-button.sys.mjs, line 17: Error: Failed to load resource:///modules/CustomizableWidgets.sys.mjs

It's in a way not unexpected as that module is Firefox-only.
I'm not even opening the devtools at that point though...
What would be the best way to avoid this console spew?

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1950884

:julienw, since you are the author of the regressor, bug 1950884, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Julien Wajsberg [:julienw]]

Interesting, this patch shouldn't change anything unless you run thunderbird with MOZ_PROFILER_STARTUP. Is that what you're doing?

Bug 1562082 could have done that but it's been backed out anyway...

By chance do you see a longer stack in the Javascript console?

Comment 3

[Magnus Melin [:mkmelin]]

I do not set the env variable no.
In the error console the full stack is available

Error: Failed to load resource:///modules/CustomizableWidgets.sys.mjs menu-button.sys.mjs:17:17
    CustomizableWidgets resource://devtools/client/performance-new/popup/menu-button.sys.mjs:17
    key resource://devtools/client/performance-new/shared/typescript-lazy-load.sys.mjs:36
    initialize resource://devtools/client/performance-new/popup/menu-button.sys.mjs:109
    hookProfilerRecordingButton resource:///modules/DevToolsStartup.sys.mjs:717
    handle resource:///modules/DevToolsStartup.sys.mjs:385

Comment 4

[Magnus Melin [:mkmelin]]

Hmm, somehow devtools.performance.popup.feature-flag was true in my profile and that was causing it.

Sorry for the noise!

Comment 5

[Julien Wajsberg [:julienw]]

In Firefox it's true in nightly and other cases: https://searchfox.org/mozilla-central/rev/1a7d78fdc729359ea43c65d647879c32bcdfb852/modules/libpref/init/all.js#656-658
Is that overridden in Thunderbird?
Bug 1950884 shouldn't have changed this behavior though!

Please file a new bug if you see this again :-) Probably we can do better in cases CustomizableWidgets is absent.

Comment 6

[Magnus Melin [:mkmelin]]

Yes it's apparently overridden in Thunderbird. https://searchfox.org/comm-central/rev/ba56385ef8c2a480f48388a49d29d4cbce03a055/mail/app/profile/all-thunderbird.js#1060