1954826 - ContentTaskUtils seems to be incorrectly configured as a global in eslint for tests

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Julien Wajsberg [:julienw]]

When adding this code:

const { ContentTaskUtils } = ChromeUtils.importESModule(
  "resource://testing-common/ContentTaskUtils.sys.mjs"
);

to devtools/client/performance-new/test/browser/helpers.js, I get an error due to the eslint rule mozilla/no-redeclare-with-import-autofix (this is in https://phabricator.services.mozilla.com/D240071).

According to :Standard8:

I think this definition is wrong.

I believe ContentTaskUtils isn't generally available, and we do have code to say it is available if particular function calls are made.

So we should probably remove it from there, and fix the few issues that are showing up.

I'll try removing the definition and see what happens.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1954826 - Remove ContentTaskUtils from the list of eslint globals for tests r=standard8

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1954826 - Add ContentTaskUtils as a global in specific test files, where it's necessary r=Standard8

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7581b670c001
Remove ContentTaskUtils from the list of eslint globals for tests r=frontend-codestyle-reviewers,mossop
https://hg.mozilla.org/integration/autoland/rev/8ea416e43464
Add ContentTaskUtils as a global in specific test files, where it's necessary r=Standard8,translations-reviewers

Comment 4

[Atila Butkovits]

Backed out for causing failures at browser_webconsole_stubs_page_error.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/c100d32451875462676eb11241ff557609efe47f

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=KhY7xa23Sku6zy9AJNkPOA.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=8ea416e43464675a851ac18b5b5bdeb5d2bcdfd7

Failure log: https://treeherder.mozilla.org/logviewer?job_id=500339391&repo=autoland&lineNumber=13867

Comment 5

[Julien Wajsberg [:julienw]]

I had to update some devtools test fixtures.
Here is a new try build after these updates:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=59dab9e465fbb3ca98a0cb2c7b8f80e993f52be7

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/190b26a351c5
Remove ContentTaskUtils from the list of eslint globals for tests r=frontend-codestyle-reviewers,mossop
https://hg.mozilla.org/integration/autoland/rev/c3c6243b121d
Add ContentTaskUtils as a global in specific test files, where it's necessary r=Standard8,translations-reviewers

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/190b26a351c5
https://hg.mozilla.org/mozilla-central/rev/c3c6243b121d