1954903 - Allow to use system libraries for gbm/drm/PipeWire instead of bundled

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement)

Description

[Jan Grulich]

We currently bundle gbm/drm/pipewire libraries for screencast/camera support in WebRTC, but it would be beneficial to have an option to use system libraries.

Comment 1

[Jan Grulich]

Attachment: Bug 1954903 - Allow to use system gbm libs instead of bundled r=stransky,mjf

Comment 2

[Jan Grulich]

Attachment: Bug 1954903 - Allow to use system drm libs instead of bundled r=stransky,mjf

Comment 3

[Jan Grulich]

Attachment: Bug 1954903 - Allow to use system PipeWire libs instead of bundled r=stransky,mjf

Comment 4

[Jan Grulich]

Attachment: Bug 1954903 - Update libwebrtc GN configs r=mjf

Regenerate moz.build files for the special handling in gn_processor.py
for gbm, drm and PipeWire libraries.

Also remove libwebrtc/third_party/[gbm,drm,pipewire] libs for which we
now have a special handling in gn_processor.py.

Generation command:
./mach python build/gn_processor.py
dom/media/webrtc/third_party_build/gn-configs/webrtc.json

Comment 5

[Jan Grulich]

Attachment: Bug 1954903 - Drop dependency on libepoxy from libwebrtc r=pehrsons,mjf

We were using libepoxy only for GL/EGL defines, but we can use GL/EGL
headers directly.

This is a simple backport of an WebRTC upstream change and also update
to moz.build files to pickup the drop of libepoxy.

Upstream commit: 839b657b184b1afa563f6456b6caeac7c25dcb23

Comment 6

[Jan Grulich]

Attachment: Bug 1954903 - WebRTC backport: PipeWire camera: drop redundant <pipewire/core.h> include r=pehrsons

We already include main <pipewire/pipewire.h> header, which includes all
the PipeWire headers, making <pipewire/core.h> to be included twice.

This breaks Firefox builds, where using system libraries we have to list
all system headers, making Firefox to unnecessarily list "core.h" header
in the list, while "pipewire.h" should be enough.

This is a simple backport of an WebRTC upstream change.
Upstream commit: 537158885bc60ffe64c2c0c8a7c89d74cb7c105b

Comment 7

[Jan Grulich]

Attachment: Bug 1954903 - Regenerate moz.build files r=mjf

Regenerate moz.build files for the special handling in gn_processor.py
for gbm, drm and PipeWire libraries and for updates in GN config files.

Generation command:
./mach python build/gn_processor.py
dom/media/webrtc/third_party_build/gn-configs/webrtc.json

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ff19ec147fca
WebRTC backport: PipeWire camera: drop redundant <pipewire/core.h> include r=pehrsons,webrtc-reviewers

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ff19ec147fca

Comment 10

[Jan Grulich]

Attachment: Bug 1954903 - Add GL/EGL headers to Ubuntu CI runners and sysroot r=mjf,glandium

With removal of libepoxy usage from WebRTC, we need GL/EGL headers to be
available during the build.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473cee020c76
Allow to use system gbm libs instead of bundled r=stransky,mjf
https://hg.mozilla.org/integration/autoland/rev/9b7841236572
Allow to use system drm libs instead of bundled r=stransky,mjf
https://hg.mozilla.org/integration/autoland/rev/792f94b3567b
Allow to use system PipeWire libs instead of bundled r=stransky,mjf
https://hg.mozilla.org/integration/autoland/rev/506d4efaf2dc
Update libwebrtc GN configs r=webrtc-reviewers,mjf
https://hg.mozilla.org/integration/autoland/rev/cae5ddd30f59
Regenerate moz.build files r=mjf,webrtc-reviewers

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/473cee020c76
https://hg.mozilla.org/mozilla-central/rev/9b7841236572
https://hg.mozilla.org/mozilla-central/rev/792f94b3567b
https://hg.mozilla.org/mozilla-central/rev/506d4efaf2dc
https://hg.mozilla.org/mozilla-central/rev/cae5ddd30f59