1954982 - There is no visual indicator for long titles on pinned tabs

Status: RESOLVED FIXED

(Firefox :: Sidebar, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 18-22]]

Attachment: image.png

Found in

• 138.0a1 (2025-03-18)

Affected versions

• 138.0a1 (2025-03-18)

Tested platforms

• Affected platforms: Windows 10x64, Ubuntu 24, macOS
• Unaffected platforms: none

Preconditions

• sidebar.expandOnHover: true
• sidebar.revamp: true
• ensure that vertical tabs are enabled

Steps to reproduce

1. Open some web pages with long titles in new tabs and pin them.
2. Hover over the sidebar launcher.
3. Observe the pinned tabs.

Expected result

• Long tab titles have a visual indicator showing they are truncated.

Actual result

• The long tab titles are cut off.

Regression range

• Not a regression, new feature.

Additional notes

• Attached a screenshot.

Comment 1

[Kelly Cochrane [:kcochrane]]

This is being fixed as part of bug 1954953

Comment 3

[Kelly Cochrane [:kcochrane]]

This was previously added in bug 1954953, but it looks like the gradient is missing for pinned tab titles. It truncates the title but the gradient isn't there.

Comment 4

[Kelly Cochrane [:kcochrane]]

Attachment: Missing_gradient.png

Comment 5

[Sarah Clements [:sclements]]

Attachment: Bug 1954982 - Expand on hover pinned tab title fix r=#sidebar-reviewers

• Add gradient for expand on hover pinned tabs by removing pinned condition

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/027a91cf580f
Expand on hover pinned tab title fix r=desktop-theme-reviewers,tabbrowser-reviewers,dao

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/027a91cf580f

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sclements, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 18-22]]

Verified fixed with 139.0a1 (2025-04-17) on Windows 10x64, macOS 12 and Ubuntu 24. The pinned tabs have a visual indicator when the tab title is longer.