Open Bug 1954988 Opened 1 month ago Updated 21 days ago

Deprecate and remove AsyncShutdown.quitApplicationGranted in favor of appShutdownConfirmed

Categories

(Toolkit :: Async Tooling, task, P1)

Product:
Toolkit
Component:
Async Tooling
Type:
task

Tracking

()

People

(Reporter: jstutte, Assigned: jstutte)

References

Details

Attachments

(1 file, 11 obsolete files)

WIP: Bug 1954988 - Remove the quitApplicationGranted barrier from AsyncShutdown. r?smaug
48 bytes, text/x-phabricator-request
Details | Review

There is a misalignment between ShutdownPhase::AppShutdownConfirmed mapping to the "quit-application" notification and the AsyncShutdown exposing quitApplicationGranted which maps (not very surprisingly) to "quit-application-granted" instead.

I think the right course of action would probably be to align this better. It might actually be enough to map this barrier to "quit-application", as there seems to be no mapping for that one, anyways.

The plan is now to:

  • introduce the new barrier appShutdownConfirmed
  • use it everywhere instead of quitApplicationGranted, landing the patches one by one with some delay
  • once finished, remove quitApplicationGranted here

There might be a slight risk of mixing those shutdowns with other things that are already happening during "quit-application", changing the relative order, but I think it is worth to check this for fallout.

See Also: → 1762840
No longer blocks: 1924461
See Also: → 1924461

No functional change, as the new barrier is not yet used.

Assignee: nobody → jstutte
Attachment #9473545 - Attachment description: WIP: Bug 1954988 - Add shutdown barrier quitApplication. r?smaug → Bug 1954988 - Add shutdown barrier quitApplication. r?smaug
Attachment #9473546 - Attachment description: WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in ContentParent. r?smaug → Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in ContentParent. r?smaug
Attachment #9473545 - Attachment description: Bug 1954988 - Add shutdown barrier quitApplication. r?smaug → Bug 1954988 - Add shutdown barrier appShutdownConfirmed. r?smaug
Depends on: 1955532

Comment on attachment 9473545 [details]
Bug 1954988 - Add shutdown barrier appShutdownConfirmed. r?smaug

Revision D242491 was moved to bug 1955532. Setting attachment 9473545 [details] to obsolete.

Attachment #9473545 - Attachment is obsolete: true

Comment on attachment 9473546 [details]
Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in ContentParent. r?smaug

Revision D242492 was moved to bug 1955532. Setting attachment 9473546 [details] to obsolete.

Attachment #9473546 - Attachment is obsolete: true
Depends on: 1955533

Comment on attachment 9473547 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in AboutHomeStartupCache. r?mconley

Revision D242493 was moved to bug 1955533. Setting attachment 9473547 [details] to obsolete.

Attachment #9473547 - Attachment is obsolete: true
Depends on: 1955534

Comment on attachment 9473548 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in SessionStore. r?#session-store-reviewers

Revision D242494 was moved to bug 1955534. Setting attachment 9473548 [details] to obsolete.

Attachment #9473548 - Attachment is obsolete: true
Depends on: 1955537

Comment on attachment 9473549 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in FxAccountsCommands. r?skhamis

Revision D242495 was moved to bug 1955537. Setting attachment 9473549 [details] to obsolete.

Attachment #9473549 - Attachment is obsolete: true

Comment on attachment 9473550 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in SyncDisconnect. r?#sync-reviewers

Revision D242496 was moved to bug 1955537. Setting attachment 9473550 [details] to obsolete.

Attachment #9473550 - Attachment is obsolete: true
Depends on: 1955540
Depends on: 1955541

Comment on attachment 9473551 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in PlacesFrecencyRecalculator. r?#places-reviewers

Revision D242497 was moved to bug 1955540. Setting attachment 9473551 [details] to obsolete.

Attachment #9473551 - Attachment is obsolete: true

Comment on attachment 9473552 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in DAPTelemetrySender. r?gjis

Revision D242498 was moved to bug 1955541. Setting attachment 9473552 [details] to obsolete.

Attachment #9473552 - Attachment is obsolete: true

Comment on attachment 9473553 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in DAPVisitCounter. r?gjis

Revision D242499 was moved to bug 1955541. Setting attachment 9473553 [details] to obsolete.

Attachment #9473553 - Attachment is obsolete: true
Depends on: 1955542
Depends on: 1955544

Comment on attachment 9473554 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in XPIProvider. r?rpl

Revision D242500 was moved to bug 1955542. Setting attachment 9473554 [details] to obsolete.

Attachment #9473554 - Attachment is obsolete: true

Comment on attachment 9473555 [details]
WIP: Bug 1954988 - Use appShutdownConfirmed instead of quitApplicationGranted in nsUserIdleService. r?dthayer

Revision D242501 was moved to bug 1955544. Setting attachment 9473555 [details] to obsolete.

Attachment #9473555 - Attachment is obsolete: true
Component: DOM: Content Processes → Async Tooling
Product: Core → Toolkit
Summary: Align AsyncShutdown.quitApplicationGranted with ShutdownPhase::AppShutdownConfirmed → Deprecate and remove AsyncShutdown.quitApplicationGranted in favor of appShutdownConfirmed
Severity: -- → S3
Priority: -- → P1
Depends on: 1959167
See Also: → 1959340

Let's not remove it before bug 1959340 is fixed.

Depends on: 1959340
See Also: 1959340 →
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: