195515 - leak of nsNativeAppSupport object

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Brian Ryner (not reading)]

We always leak the nsNativeAppSupport object because of a refcounting error:

- The object is initially created with a refcount of 1, by main()
- The object is passed to main1(), which assigns it into a nsCOMPtr (refcnt->2)
- The object is passed to the nsAppShellService, which stores it into a member
variable (refcnt->3)

On shutdown:
- The appshell service goes away (refcnt->2)
- main1() exits, releasing the nsCOMPtr (refcnt->1)

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

use dont_AddRef when assigning into the nsCOMPtr in main1(), since the object
is passed in with a refcount of 1.

Comment 2

[Brian Ryner (not reading)]

Appears to have been introduced by lordpixel's checkin for bug 90823.

Comment 3

[Bradley Baetz (:bbaetz)]

Comment on attachment 115968 [details] [diff] [review]
patch

r=bbaetz.

Not that it really matters that we leak something which can't be released until
main() is ending anyway, but hey....

Comment 4

[Brian Ryner (not reading)]

checked in.