Closed Bug 1955185 Opened 1 month ago Closed 1 month ago

Confirmation hints: don't generate Fluent IDs at run-time

Categories

(Toolkit :: Form Autofill, task)

Product:
Toolkit
Component:
Form Autofill
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: flod, Assigned: flod)

Details

Attachments

(1 file)

Bug 1955185 – Create an explicit map of Fluent IDs for autofill hints, r=#credential-management-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

Generating Fluent IDs at run-time makes maintenance harder (you can't find the IDs in the codebase), and updates even harder (a change to one string would require changing the code, or changing all of them).

https://searchfox.org/mozilla-central/source/toolkit/components/formautofill/default/FormAutofillPrompter.sys.mjs#1440-1442

Pushed by flodolo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/863d6d7ba875 – Create an explicit map of Fluent IDs for autofill hints, r=credential-management-reviewers,dimi

https://hg.mozilla.org/mozilla-central/rev/863d6d7ba875

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: