1955241 - Menu Bar context menu has an extra divider

Status: VERIFIED FIXED

(Firefox :: Menus, defect, P3)

Description

[Giorgia Nichita, Release Desktop QA]

Attachment: extra divider.PNG

Found in:

• 137.0b8

Affected versions:

• 138.0a1
• 137.0b8

Tested platforms:

• Affected platforms: Windows 10, Windows 11, Ubuntu 22
• Unaffected platforms: macOS

Steps to reproduce:

1. Open Firefox.
2. Enable the Menu Bar (right-click on the toolbar, select Menu Bar).
3. Right-click on the Menu Bar.
4. Observe the context menu layout.

Expected result:

• The context menu should not have an extra divider.

Actual result:

• An extra divider appears in the context menu.

Regression range:

• Regressed by: Bug 1948342

Additional notes:

• Screenshot attached.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948342

:nsharpley, since you are the author of the regressor, bug 1948342, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1948342

Comment 4

[Dão Gottwald [:dao]]

Do you have plans on fixing this? Would you mind setting a priority? I realize there's not much user impact here other than it looking funky, so I think it's more of a tech debt thing that could make it harder to properly add new menu items in the future.

Comment 5

[Punam Dahiya [:pdahiya]]

With 'Turn on Vertical Tabs' added as Menu Item, this issue is no longer reproducible in latest Firefox . NI QA to help validate and close the bug. Thanks!

Comment 6

[Kestrel]

Attachment: Extra separator on latest 2025-09-26

I still see it on latest Nightly 145.0a1 (2025-09-26), make sure you have the menu bar enabled.

Comment 7

[Giorgia Nichita, Release Desktop QA]

I re-tested on Firefox Nightly 145.0a1 (2025-09-26) and the issue is still reproducible. The extra divider only appears when the Menu Bar is enabled and it does not appear if the Menu Bar is disabled. This behavior is consistent across Windows, Linux, and Ubuntu.

Comment 8

[log101]

Hi, I've built and run Firefox and able to navigate through the codebase. I've also examined the the bug 1948342. I'd love to work on this issue if you don't mind.

Comment 9

[Nikki Sharpley (:nikkis) (she/her)]

Thanks log101! Do you have access to a Linux or Window system to be able to work on this? If so, please go ahead and reach out on here if you need any assistance getting a patch up for review.

Comment 10

[log101]

Yes, I have access to a Linux system. I also have a Windows system where I can verify if my fix works. I’ll be working on this issue then, thanks.

Comment 11

[Kyler Riggs [:kylr]]

I created a patch to fix this issue last night. I am unsure who I should tag as the reviewer on the commit.

Comment 12

[Kyler Riggs [:kylr]]

Attachment: Bug 1955241 - Fix separator appearing at top of toolbar context menu with no items above it. r=nsharpley

Comment 13

[Nikki Sharpley (:nikkis) (she/her)]

:log101, looks like :klyr has already submitted a patch. If you haven't started yet, I'd recommend finding something else to work on here with the good-first-bug tag.

:kylr, thanks for the patch! Next time comment on the bug if you'd like to work on it that way no one else starts working on it at the same time :) Guidelines for finding something to work on are here.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b92a320b1273
https://hg.mozilla.org/integration/autoland/rev/886d6082fb47
Fix separator appearing at top of toolbar context menu with no items above it. r=nsharpley

Comment 15

[Kyler Riggs [:kylr]]

(In reply to Nikki Sharpley (:nikkis) (she/her) from comment #13)

:kylr, thanks for the patch! Next time comment on the bug if you'd like to work on it that way no one else starts working on it at the same time :) Guidelines for finding something to work on are here.

My apologies! I tried to reach out to you on chat the day before submitting but I should have also left a comment.

Comment 16

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/886d6082fb47

Comment 17

[Dana Lucaci, Desktop QA]

Reproduced with Firefox 138.0a1 (2025-03-20) on Windows 10.
Verified as fixed with Firefox 146.0a1 (20251028094950) and Firefox 145.0b8 (20251029090400) on Win 10 and Ubuntu 22.