Closed Bug 1955246 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 51487 - Corner-shape: fix border thickness for high curvature

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51487 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51487
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

Corner-shape: fix border thickness for high curvature

When curvature is very high (>2) or very low (\<0.5),
we can no longer adjust the offset. Instead, to create
an effect that makes the thickness consistent, we adjust
the curvature of the target corner upwards, to the point
in which the mid-point has the desired length.

Bug: 399449172
Change-Id: I7285bccaa48664179f39c44ebac562514a306e1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6372625
Commit-Queue: Noam Rosenthal \<nrosenthal@chromium.org>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1435336}

PR 51487 applied with additional changes from upstream: cff189855b099d5aff7a1ec1a54c05c996ffe957
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 24 tests

Status Summary

Firefox

PASS: 4
FAIL: 20

Chrome

PASS: 21
FAIL: 3

Safari

PASS: 4
FAIL: 20

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2d714b62b0e1 [wpt PR 51487] - Corner-shape: fix border thickness for high curvature, a=testonly https://hg.mozilla.org/integration/autoland/rev/caa823a4a88d [wpt PR 51487] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2d714b62b0e1
https://hg.mozilla.org/mozilla-central/rev/caa823a4a88d

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.