Closed Bug 1955329 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 51494 - [carousel] Implement scroll-marker-contain property logic

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51494
Details from upstream follow.

Daniil Sakhapov <sakhapov@chromium.org> wrote:

[carousel] Implement scroll-marker-contain property logic

This CL adds logic to collect html anchor element to
scroll-marker-contain containers to support scroll tracking to determine
the active one.

When we detect any element with scroll-marker-contain property we mark
Document that it needs to do an extra pass to collect all
scroll-marker-contain elements and corresponding anchor elements.

After that collection we subscribe each scroll-marker-contain element's
ScrollMarkerGroupData to each scroller that owns any of group's scroll
targets (e.g. scroll marker is \<a href="#target"> then scroll target
is some element with id="target" and scroller is closest ancestor
scroller of scroll target).

This way scrollers will notify scroll marker groups of any scrolls so
that we need to do scroll tracking of active (:target-current) scroll
marker.

This CL also lacks some invalidation logic and invalidation tests, those
will be added together in following CLs.

Bug: 398065922
Change-Id: I9eaa5f6bf0ffb62dded2f45b509964c161f70408
Reviewed-on: https://chromium-review.googlesource.com/6357113
WPT-Export-Revision: 64e3e6e6f84cc874f177e870295c10c51f7bbe6c

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

FAIL: 4

Chrome

FAIL: 4

Safari

FAIL: 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/334b3c55704c [wpt PR 51494] - [carousel] Implement scroll-marker-contain property logic, a=testonly https://hg.mozilla.org/integration/autoland/rev/cf471529f0e6 [wpt PR 51494] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/334b3c55704c
https://hg.mozilla.org/mozilla-central/rev/cf471529f0e6

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.