195538 - Toolbar separators and lines should use native colors on Windows XP

Status: RESOLVED WONTFIX

(Core Graveyard :: Skinability, defect)

Description

[Lu Timdale]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030227 Phoenix/0.5
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3b) Gecko/20030227 Phoenix/0.5

While the toolbar edge looks like the native one in Windows 2000, in Windows XP,
it is too dark.  XP uses softer toolbar edges.  Look at IE for expected behaviour.

Reproducible: Always

Steps to Reproduce:
1. Use new default theme (based on Qute)
2.
3.



Expected Results:  
Have a softer edge between toolbars.

Comment 1

[Lu Timdale]

Attachment: Image of Toolbars in IE and Phonenix

Toolbars edges in Windows XP in IE are softer than the ones in phoenix.

Comment 2

[David Tenser [:djst]]

The problem is that the Luna interface in Windows XP is using special (fixed)
colors for the toolbar separators. All other os'es are using a 3dshadow color,
which is set by the OS. 

If we would use the lighter Luna XP color, that color would have to be hardcoded
in the theme, meaning that even if you were using Windows 98 with a
high-contrast scheme, you would still be using that color for the toolbar separator.

In the end, this is a XUL issue and not a Phoenix-specific problem. Don't really
know what to do with this bug... (qawanted)

Comment 3

[Simon Paquet [:sipaq]]

Hardcoding colors into a theme is evil[tm]. IMO this is as WONTFIX or INVALID.

Comment 4

[Lu Timdale]

I find it hard to believe that there is no setting in the Luna toolbar APIs that
references the color, although I was unable to find it on msdn.  

I had thought that the goal of phoenix's new default theme was to look as native
as possible.  It would be a shame to ignore this one, since it makes the
application look different on XP.

Comment 5

[David Tenser [:djst]]

This bug in itself is a WONTFIX, but I don't want to resolve it as such yet.

If not already filed, it should be a rfe about using the native toolbar
separator color(s) in WinXP and should be moved to a Mozilla component instead
of Phoenix.

Comment 6

[David Tenser [:djst]]

Changing summary. 
This bug is about making the color of toolbar separators and toolbar lines
native in Windows XP Luna theme. Compare the colors in the attached screenshot
to see what's wrong.

Comment 7

[Asa Dotzler [:asa]]

->default contacts

Comment 8

[Chris Cunningham]

So long as it's being hard-coded, it really should be hardcoded to the right
colour (which looks to be rgb(210,210,192) or thereabouts). I might have a crack
at a two-line patch to get this squeezed in before beta 2.

 - Chris