1955407 - Add new styling for marketing card

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, task, P1)

Description

[Hanna Alemu [:hanna_a]]

Add new styling to support marketing onboarding card optimization experiment.

Comment 1

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1955407 - Add new styling for marketing card

Comment 2

[Hanna Alemu [:hanna_a]]

Comment on attachment 9473448 [details]
Bug 1955407 - Add new styling for marketing card

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Required for a 137 experiment to optimize the Onboarding marketing card.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enroll in a treatment branch of this experiment: https://experimenter.services.mozilla.com/nimbus/android-marketing-card-optimization/summary. Re-set/restart app to view onboarding, and observe the marketing card.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only changes UI/Styling and is enabled through a nimbus experiment. Default experience is not affected.
• String changes made/needed: no
• Is Android affected?: Yes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45f326b9b752
Add new styling for marketing card r=android-reviewers,boek

Comment 4

[Atila Butkovits]

Backed out for causing fenix failures at OnboardingMapperTest.kt.

Backout link: https://hg.mozilla.org/integration/autoland/rev/7a01326150919027492898e694bb8e91601b3be8

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=fenix%2Copt%2Cfenix%2Cbuilds%2Cmade%2Cfor%2Ctesting%2Ctest-apk-fenix-debug%2Ct&revision=7d198c9f032e6c16d7f9798c504b3b5708ce9760

Failure log: https://treeherder.mozilla.org/logviewer?job_id=500221828&repo=autoland&lineNumber=3048

Comment 5

[Pascal Chevrel:pascalc]

Comment on attachment 9473448 [details]
Bug 1955407 - Add new styling for marketing card

Patch causing failures in mozilla-central and we build our last beta shortly.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f211c2146127
Add new styling for marketing card r=android-reviewers,boek

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/f211c2146127

Comment 8

[Hanna Alemu [:hanna_a]]

Attachment: Bug 1955407 - Revert Add new styling for marketing card

This reverts commit 2011a437c40c6f9669bd4eb795f44f9e9bb72a7b.

Comment 9

[Hanna Alemu [:hanna_a]]

Reverting changes as the experiment has been put on hold https://phabricator.services.mozilla.com/D243006

CC @vtamas

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Comment 11

[Phabricator Automation]

Comment on attachment 9474491 [details]
Bug 1955407 - Revert Add new styling for marketing card

Revision D243006 was moved to bug 1956552. Setting attachment 9474491 [details] to obsolete.

Comment 12

[Hanna Alemu [:hanna_a]]

Attachment: Revert "Bug 1955407 - Add new styling for marketing card r=#android-reviewers,boek"

This reverts commit 2011a437c40c6f9669bd4eb795f44f9e9bb72a7b.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/847bac5794cd
Revert "Bug 1955407 - Add new styling for marketing card r=android-reviewers,Roger"

Comment 14

[Serban Stanca [:SerbanS]]

Revert patch merged in mozilla-central: https://hg.mozilla.org/mozilla-central/rev/847bac5794cda1c34b87f05c6fd212fe048b7ef3.

Hi @hanna_a! Should we reopen the bug in this case? Is it reverted to the failing state from before?

Thank you for your answer!

Comment 15

[Hanna Alemu [:hanna_a]]

Hi @Serban, thanks for reaching out! This bug was to add a new layout for a experiment, but there was no issue with the previous state. We don't need to re-open the bug since the experiment has been cancelled.