1955539 - comm-central not updating on Phabricator

Status: RESOLVED FIXED

(Conduit :: Administration, task)

Description

[Daniel Darnell [:dandarnell]]

Currently, Thunderbird pushes to comm-central do not close the corresponding Phabricator revisions to each patch in the push. We suspect this is related to the recent Lando update.

After a bit of digging, I suspect it partially has to do with the switch to identifying repos by unique short_names. I noticed the new config for Thunderbird doesn't seem to have short_names added to Thunderbird's repos.

Comment 1

[Daniel Darnell [:dandarnell]]

@zeid I can write a patch to update comm-* repo info for the new Lando, but I wanted to check with you: am I off-base/missing other commits I should be porting for Thunderbird?

Comment 2

[Zeid [:zeid]]

Hi Daniel,

The create_environment_repos script was meant as an initial script to populate the DB. comm-central has in fact been added to the new Lando with comm-central as the short_name. However, I did find this error in Phabricator:

Pull of 'comm-central' failed: Command failed with error #255!
...
abort: working directory of ***: timed out waiting for lock held by ***' 

So it looks like an issue with Phabricator.

Comment 3

[Toby Pilling [:tobyp]]

FYI I also get a 502 error whenever I try to access the raw diff (hosted on Cloudfront) from Phabricator.

As an example, click "Download Raw Diff" from this patch and you are taken to a 502 error at this URL.

Comment 4

[David Lawrence [:dkl]]

(In reply to Zeid [:zeid] from comment #2)

Hi Daniel,

The create_environment_repos script was meant as an initial script to populate the DB. comm-central has in fact been added to the new Lando with comm-central as the short_name. However, I did find this error in Phabricator:

Pull of 'comm-central' failed: Command failed with error #255!
...
abort: working directory of ***: timed out waiting for lock held by ***' 

So it looks like an issue with Phabricator.

This is fixed now. Turned out to be a stale lock file in .hg that once removed, Phabricator was able to continue to import recent changes successfully.

Comment 5

[Daniel Darnell [:dandarnell]]

(In reply to David Lawrence [:dkl] from comment #4)

(In reply to Zeid [:zeid] from comment #2)

Hi Daniel,

The create_environment_repos script was meant as an initial script to populate the DB. comm-central has in fact been added to the new Lando with comm-central as the short_name. However, I did find this error in Phabricator:

Pull of 'comm-central' failed: Command failed with error #255!
...
abort: working directory of ***: timed out waiting for lock held by ***' 

So it looks like an issue with Phabricator.

This is fixed now. Turned out to be a stale lock file in .hg that once removed, Phabricator was able to continue to import recent changes successfully.

Thank you for taking the time to look at this! It is greatly appreciated.