Closed
Bug 195555
Opened 22 years ago
Closed 22 years ago
NS_InitEmbedding fails to return an error if NS_InitXPCOM2 fails
Categories
(Core Graveyard :: Embedding: APIs, defect)
Core Graveyard
Embedding: APIs
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.5alpha
People
(Reporter: sfraser_bugs, Assigned: adamlock)
References
()
Details
Attachments
(1 file)
1.08 KB,
patch
|
sfraser_bugs
:
review+
dougt
:
superreview+
sspitzer
:
approval1.4+
|
Details | Diff | Splinter Review |
NS_InitEmbedding throws away the return value from NS_InitXPCOM2. This is not
helpful for embedders.
Reporter | ||
Updated•22 years ago
|
OS: MacOS X → All
Hardware: Macintosh → All
Comment 1•22 years ago
|
||
This is either conrad's, or locke's. I agree, the result should bubble up.
Assignee: dougt → adamlock
Component: Embedding: GRE Core → Embedding: APIs
QA Contact: ashishbhatt → carosendahl
Patch propogates the error code from NS_InitXPCOM2 & NS_ShutdownXPCOM.
Reporter | ||
Comment 3•22 years ago
|
||
Comment on attachment 122875 [details] [diff] [review]
Patch
Looks OK to me.
Attachment #122875 -
Flags: superreview?(dougt)
Attachment #122875 -
Flags: review+
Updated•22 years ago
|
Attachment #122875 -
Flags: superreview?(dougt) → superreview+
Comment on attachment 122875 [details] [diff] [review]
Patch
Seeking 1.4 checkin approval for embedding specific and obvious patch to
improve error return codes.
Attachment #122875 -
Flags: approval1.4?
Comment 5•22 years ago
|
||
Comment on attachment 122875 [details] [diff] [review]
Patch
a=sspitzer for 1.4 final
Attachment #122875 -
Flags: approval1.4? → approval1.4+
Fix checked in
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•