Closed Bug 1955573 Opened 1 month ago Closed 1 month ago

Tab groups color: don't generate Fluent IDs at run-time

Categories

(Firefox :: Tabbed Browser, task)

Product:
Firefox
Component:
Tabbed Browser
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: flod, Assigned: flod)

Details

Attachments

(1 file)

Bug 1955573 - Don't generate Fluent IDs at run-time for Tab Group colors, r=#tabbrowser-reviewers!
48 bytes, text/x-phabricator-request
Details | Review

We're currently generating Fluent IDs at run-time for colors
https://searchfox.org/mozilla-central/source/browser/components/tabbrowser/content/tabgroup-menu.js#503-506

We should avoid doing that, as it makes maintenance and finding unused strings unnecessarily harder, and the number of strings is relatively small.

Pushed by flodolo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/809b37f850f1 Don't generate Fluent IDs at run-time for Tab Group colors, r=tabbrowser-reviewers,nsharpley

https://hg.mozilla.org/mozilla-central/rev/809b37f850f1

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: