1955595 - [Trending searches] Trending searches are displayed when there is no internet connection

Status: RESOLVED FIXED

(Firefox for Android :: Search, defect)

Description

[Mira Lobontiu (Android QA)]

Prerequisites

1. Enable the following options in Secret Settings:

• Enable Trending Searches
• Enable Recent Searches
• Enable Shortcut Suggestions.

2. Make sure the default search engine is either Google or Bing.
3. Currently trending searches are only supported in Google in the US and Bing in US and Canada.

Steps to reproduce

1. Open a website.
2. After it is loaded, cut off the internet connection.
3. Tap on the address bar.

Expected behavior

With no internet connection then there should NOT be any trending searches. But will still have recent searches and shortcut suggestions.

Actual behavior

Trending searches are displayed even with no internet connection alongside with recent searches and shortcut suggestions.
Even when the app is closed entirely, and re-opened, the trending searches are still displayed.

Letting the app in the background for a while (1-2 minutes) fixes the issue.

Device information

• Firefox version: Nightly 138.0a1 from 3/20
• Android device: Google Pixel 6 (Android 15)

Comment 1

[Sanchaai [:sanchaai]]

Attachment: Bug 1955595 - Turn off caching and omit cookies when requesting trending searches. r=Roger

Turn off caching and omit cookies when requesting trending searches, to ensure trending searches are not displayed when there is no internet connection.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1604defafc9
Turn off caching and omit cookies when requesting trending searches. r=Roger,android-reviewers

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d1604defafc9

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:sanchaai, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox138 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 139.0a1 from 4/9 with Oppo Find N2 Flip (Android 15).

Still reproducible on Firefox for Android Beta 138.0b5 with the same device.