Support Home button on Internet keyboards

NEW
Unassigned

Status

()

Core
Keyboard: Navigation
--
enhancement
15 years ago
9 years ago

People

(Reporter: Dean Tessman, Unassigned)

Tracking

Trunk
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

15 years ago
A continuation of bug 30431, we can now easily add support for the Home button.
 Unfortunately there's no interface I can find to tell the browser to load the
home page, as GlobalWindowImpl::Home is not exposed.  The easiest thing for me
to do is just copy the code out of there into
nsEventStateManager::PostHandleEvent.  Any objections to that?  It's only 15 or
20 lines of code.

Comment 1

15 years ago
I suspect there are objections to adding 20 lines of code to support the Home
button on internet keyboards. We've been fighting bloat for a while, battling
over each additional unnecessary line of code during code reviews. Isn't there a
better way than copy/paste?

Comment 2

15 years ago
hear hear, good spot aaron. Here's a perfect opportunity to consolidate some
code. Are there other places that these same lines have been copy/pasted, that
we could also consolidate?
(Reporter)

Comment 3

15 years ago
We do something similar in at least navigator.js.
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/navigator.js#771

I wonder if the nsGlobalWindowImpl::Home code is even used, as it doesn't
support a home page group.

http://lxr.mozilla.org/mozilla/source/dom/src/base/nsGlobalWindow.cpp#2437

Updated

15 years ago
Summary: Support Home button on internet keyboards → Support Home button on Internet keyboards
(Reporter)

Updated

14 years ago
Assignee: dean_tessman → aaronleventhal
QA Contact: bugzilla

Comment 4

11 years ago
This is (hopefully) the last obstacle for ditching Internet Explorer. Has there been any progress lately???
Mass un-assigning bugs assigned to Aaron.
Assignee: aaronleventhal → nobody

Comment 6

9 years ago
This was fixed in FF 3.0
QA Contact: keyboard.navigation
You need to log in before you can comment on or make changes to this bug.