195560 - Support Home button on Internet keyboards

Status: NEW

(Core :: DOM: UI Events & Focus Handling, enhancement)

Description

[:deanis74]

A continuation of bug 30431, we can now easily add support for the Home button.
 Unfortunately there's no interface I can find to tell the browser to load the
home page, as GlobalWindowImpl::Home is not exposed.  The easiest thing for me
to do is just copy the code out of there into
nsEventStateManager::PostHandleEvent.  Any objections to that?  It's only 15 or
20 lines of code.

Comment 1

[Aaron Leventhal]

I suspect there are objections to adding 20 lines of code to support the Home
button on internet keyboards. We've been fighting bloat for a while, battling
over each additional unnecessary line of code during code reviews. Isn't there a
better way than copy/paste?

Comment 2

[Alec Flett]

hear hear, good spot aaron. Here's a perfect opportunity to consolidate some
code. Are there other places that these same lines have been copy/pasted, that
we could also consolidate?

Comment 3

[:deanis74]

We do something similar in at least navigator.js.
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/navigator.js#771

I wonder if the nsGlobalWindowImpl::Home code is even used, as it doesn't
support a home page group.

http://lxr.mozilla.org/mozilla/source/dom/src/base/nsGlobalWindow.cpp#2437

Comment 4

[Mattias Jiderhamn]

This is (hopefully) the last obstacle for ditching Internet Explorer. Has there been any progress lately???

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Mass un-assigning bugs assigned to Aaron.

Comment 6

[Mattias Jiderhamn]

This was fixed in FF 3.0