1955711 - Bookmarks bar empty, pinned extensions gone (again!) (maybe due to toggling new sidebar / vertical tabs)

Status: RESOLVED WORKSFORME

(Firefox :: Toolbars and Customization, defect)

Description

[juraj.masiar]

Attachment: broken_toolbar_again.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:137.0) Gecko/20100101 Firefox/137.0

Steps to reproduce:

My toolbar got wiped out again, same as here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1919721

I'm running 137.0b9 version.
I did enabled vertical tabs yesterday, but only for a moment.
I've also enabled the new Sidebar, which is now present in each new window I open (even if I hide it).

Comment 1

[juraj.masiar]

After the restart, the toolbar is still empty, but at least the sidebar is finally gone - but I can still see it for a moment when new window is created.
Also, each time I open new window, there is an exception in the browser console:

 NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIFaviconService.setFaviconForPage]
    setIconFromLink resource:///actors/LinkHandlerParent.sys.mjs:141
    receiveMessage resource:///actors/LinkHandlerParent.sys.mjs:54

I have to say, all these new features feels quite buggy, I hope they are not part of the upcoming release...

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'WebExtensions::Untriaged' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hi juraj.masiar,

Can you tell me more about your configuration? Are you using any userChrome.css or autoconfig tweaks?

This is hauntingly similar to bug 1919721. The problem with bugs like this is that the bug only happens once, during the initial start that mangles the toolbar. Subsequent restarts (at least for bug 1919721) didn't cause the bug to reappear.

So I'm curious what happens if you use Customize Mode to put the buttons back into their expected positions and restart the browser. Does the bug recur?

Comment 4

[juraj.masiar]

Hello Mike,
I'm using only userChrome.css, and it's a super simple one (it shortens extension name in new tab page):

#identity-box.extensionPage #identity-icon-label {
  visibility: collapse !important;
  transition: visibility 250ms ease-in-out;
}
#identity-box.extensionPage:hover #identity-icon-label {
  visibility: visible !important;
  transition: visibility 250ms ease-in-out 500ms;
}

Other than that, it's a normal Firefox profile.
I remember bug 1919721 comment 19 clearly, because I was affected by it.
So seeing this happen again after few months was quite a surprise.

I did use the Customize / Restore Defaults already and restarted and everything is fine now.
Well, except for the sidebar which is now for a millisecond visible when I'm creating new window. I should probably create a separate bug for that (I'll see if I can reproduce it with a new profile).

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Thanks, juraj.masiar.

I realize this is a long-shot, but you wouldn't happen to have any profile backups from prior to when this bug first appeared for you, would you? Otherwise, I worry we might have to close this as INCOMPLETE, as there's currently no known way to reproduce it.

Comment 6

[juraj.masiar]

Of course I have a profile backups :D, but last one is from June 2024.
I'll see if I can reproduce it there.
I guess I should make a new backup first and also disconnect internet so I don't break my Firefox Sync somehow...

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to juraj.masiar from comment #6)

Of course I have a profile backups :D, but last one is from June 2024.

Oh wow! Yes, if you're able to reproduce with that profile, then what I'm really interested in is the state of the browser.uiCustomization.state pref, the browser.uiCustomization.horizontalTabsBackup pref, the browser.uiCustomization.horizontalTabstrip pref and the browser.uiCustomization.navBarWhenVerticalTabs pref from the profile before the bug appears.

I'll see if I can reproduce it there.
I guess I should make a new backup first and also disconnect internet so I don't break my Firefox Sync somehow...

You can create a copy of the profile directory, and I believe if you delete the signedInUser.json file in the profile, it'll fail to login to your account and sync.

Comment 8

[juraj.masiar]

I've restored my old profile (June 2024) and checked the values for the 4 pref, but only the first was present:

browser.uiCustomization.state:
{"placements":{"widget-overflow-fixed-list":["profiler-button","sidebar-button","library-button","firefox-view-button"],"unified-extensions-area":["admin_fastaddons_com_savemypassword-browser-action","juraj_masiar_gmail_com_scrollanywhere-browser-action","_cd7e22de-2e34-40f0-aeff-cec824cbccac_-browser-action","display-anchors_robwu_nl-browser-action","_f316fd83-cc84-40a1-9fe0-86516e21e8b4_-browser-action","admin_fastaddons_com_fastfirefoxsend-browser-action","dark-mode-website-switcher_rugk_github_io-browser-action","_16a49f65-1369-4839-a5ef-db2581e08b16_-browser-action","_testpilot-containers-browser-action","_5caff8cc-3d2e-4110-a88a-003cc85b3858_-browser-action","admin_fastaddons_com_newwindowsetup-browser-action","enhancerforyoutube_maximerf_addons_mozilla_org-browser-action","private-relay_firefox_com-browser-action","_762f9885-5a13-4abd-9c77-433dcd38b8fd_-browser-action","_4b726fbc-aba9-4fa7-97fd-a42c2511ddf7_-browser-action"],"nav-bar":["back-button","forward-button","stop-reload-button","home-button","_16cbd87c-eb99-4f5c-9825-83cf13ab7ff8_-browser-action","_breadcrumbus-browser-action","_c580e2d6-885a-4cb9-af49-59b3b48350e9_-browser-action","vertical-spacer","_d5ac33ed-723c-402b-b17c-e7bbb0d3a80d_-browser-action","urlbar-container","save-to-pocket-button","customizableui-special-spring1","customizableui-special-spring41","search-container","downloads-button","fxa-toolbar-menu-button","jid1-93wyvpgvxzgatw_jetpack-browser-action","admin_fastaddons_com_webtranslate-browser-action","admin_fastaddons_com_groupspeeddial-browser-action","admin_fastaddons_com_privatenotes-browser-action","admin_fastaddons_com_sendnotetodevice-browser-action","admin_fastaddons_com_series-browser-action","_fcf60470-b210-4c17-969e-9ae01491071e_-browser-action","jid1-koqzhmowlztafg_jetpack-browser-action","admin_fastaddons_com_autohighlight-browser-action","ublock0_raymondhill_net-browser-action","firemonkey_eros_man-browser-action","_82a01566-f5cf-4c86-9aec-7da38b2a7385_-browser-action","firefoxcolor_mozilla_com-browser-action","jid1-kkzogwgsw3ao4q_jetpack-browser-action","addon_darkreader_org-browser-action","admin_fastaddons_com_facebooksponsoredadblock-browser-action","_8eed83a1-d87a-4103-8272-f226d56d3c29_-browser-action","_a6c4a591-f1b2-4f03-b3ff-767e5bedf4e7_-browser-action","danabok16_gmail_com-browser-action","firefoxaddon_zohonotebook_com-browser-action","_6c593866-3790-4c8e-8a38-7d06ea71b960_-browser-action","_f5eca307-f4c6-4120-89e1-1b32c0262944_-browser-action","_8fbc7259-8015-4172-9af1-20e1edfbbd3a_-browser-action","myallychou_gmail_com-browser-action","jid1-93cwpmrbvpjrqa_jetpack-browser-action","_f8829f14-24b7-4e17-8bde-250217de2d71_-browser-action","printedit-we_dw-dev-browser-action","savepage-we_dw-dev-browser-action","firefox_tampermonkey_net-browser-action","admin_fastaddons_com_searchresultpreviews-browser-action","admin_fastaddons_com_tabsync-browser-action","firefox-translations-addon_mozilla_org-browser-action","admin_fastaddons_com_reloader-browser-action","admin_fastaddons_com_ai-browser-action","support_todoist_com-browser-action","_b9db16a4-6edc-47ec-a1f4-b86292ed211d_-browser-action","unified-extensions-button","reset-pbm-toolbar-button"],"toolbar-menubar":["menubar-items"],"TabsToolbar":["tabbrowser-tabs","new-tab-button","alltabs-button"],"PersonalToolbar":["managed-bookmarks"]},"seen":["developer-button","_testpilot-containers-browser-action","admin_fastaddons_com_savemypassword-browser-action","_16a49f65-1369-4839-a5ef-db2581e08b16_-browser-action","_cd7e22de-2e34-40f0-aeff-cec824cbccac_-browser-action","_fcf60470-b210-4c17-969e-9ae01491071e_-browser-action","admin_fastaddons_com_series-browser-action","admin_fastaddons_com_groupspeeddial-browser-action","admin_fastaddons_com_tabsync-browser-action","jid1-93wyvpgvxzgatw_jetpack-browser-action","jid1-kkzogwgsw3ao4q_jetpack-browser-action","juraj_masiar_gmail_com_scrollanywhere-browser-action","ublock0_raymondhill_net-browser-action","_16cbd87c-eb99-4f5c-9825-83cf13ab7ff8_-browser-action","dark-mode-website-switcher_rugk_github_io-browser-action","jid1-koqzhmowlztafg_jetpack-browser-action","firemonkey_eros_man-browser-action","_82a01566-f5cf-4c86-9aec-7da38b2a7385_-browser-action","admin_fastaddons_com_sendnotetodevice-browser-action","firefoxcolor_mozilla_com-browser-action","firefox_tampermonkey_net-browser-action","admin_fastaddons_com_fastfirefoxsend-browser-action","admin_fastaddons_com_facebooksponsoredadblock-browser-action","display-anchors_robwu_nl-browser-action","addon_darkreader_org-browser-action","profiler-button","_f316fd83-cc84-40a1-9fe0-86516e21e8b4_-browser-action","admin_fastaddons_com_privatenotes-browser-action","_8eed83a1-d87a-4103-8272-f226d56d3c29_-browser-action","admin_fastaddons_com_autohighlight-browser-action","private-relay_firefox_com-browser-action","admin_fastaddons_com_webtranslate-browser-action","_a6c4a591-f1b2-4f03-b3ff-767e5bedf4e7_-browser-action","danabok16_gmail_com-browser-action","_5caff8cc-3d2e-4110-a88a-003cc85b3858_-browser-action","firefoxaddon_zohonotebook_com-browser-action","admin_fastaddons_com_newwindowsetup-browser-action","_6c593866-3790-4c8e-8a38-7d06ea71b960_-browser-action","_f5eca307-f4c6-4120-89e1-1b32c0262944_-browser-action","save-to-pocket-button","_8fbc7259-8015-4172-9af1-20e1edfbbd3a_-browser-action","_breadcrumbus-browser-action","_c580e2d6-885a-4cb9-af49-59b3b48350e9_-browser-action","_d5ac33ed-723c-402b-b17c-e7bbb0d3a80d_-browser-action","myallychou_gmail_com-browser-action","enhancerforyoutube_maximerf_addons_mozilla_org-browser-action","jid1-93cwpmrbvpjrqa_jetpack-browser-action","_f8829f14-24b7-4e17-8bde-250217de2d71_-browser-action","printedit-we_dw-dev-browser-action","savepage-we_dw-dev-browser-action","admin_fastaddons_com_searchresultpreviews-browser-action","firefox-translations-addon_mozilla_org-browser-action","_762f9885-5a13-4abd-9c77-433dcd38b8fd_-browser-action","admin_fastaddons_com_reloader-browser-action","_4b726fbc-aba9-4fa7-97fd-a42c2511ddf7_-browser-action","admin_fastaddons_com_ai-browser-action","support_todoist_com-browser-action","_b9db16a4-6edc-47ec-a1f4-b86292ed211d_-browser-action"],"dirtyAreaCache":["nav-bar","widget-overflow-fixed-list","toolbar-menubar","TabsToolbar","PersonalToolbar","unified-extensions-area"],"currentVersion":21,"newElementCount":68}

However, I was unable to reproduce it, no matter what.
But now I remember, in both cases it happened during the Firefox update. So maybe normal restart is not enough?

Anyway, at least I've managed to reproduce two other bugs related to sidebar, I'll create separate issue for that.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

But now I remember, in both cases it happened during the Firefox update. So maybe normal restart is not enough?

Another Beta build should go out this week, plus a major version bump - let's see if it recurs? If it doesn't, we might have to close this as INCOMPLETE. :/

Comment 10

[juraj.masiar]

All OK after the update. Maybe I just got super unlucky...
If I see it again, I'll recreate my profile, it's probably too old anyway.