1956029 - The suggested Tabs panel does not have a scroll bar and the Cancel and Done buttons are not visible with a lot of tab suggestions

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: Screenshot from 2025-03-24 17-59-22.png

Found in

• Nightly 138.0a1 (2025-03-24)

Affected versions

• Nightly 138.0a1 (2025-03-24)

Affected platforms

• all

Preconditions
Enable Smart Tab groups.

Steps to reproduce

1. Have a least 30 similar tabs in the Tab strip.
2. Right Click a tab and create a new group.
3. Click the Suggest more tabs button and Continue opting in.
4. Wait for the Tab suggestions to load.

Expected result

• The Tab suggestions panel should have a scroll bar.

Actual result

• There is no scroll bar for the tabs suggestions panel and the cancel and Done buttons are out of view.

Regression range
Not a regression.

Comment 1

[rrando]

Cap at 10 tabs for now

Comment 3

[Vasish Baungally]

Attachment: Bug 1956029 - Limit number of tabs suggested to 10. r?rrando

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11d95e168d7b
Limit number of tabs suggested to 10. r=rrando,tabbrowser-reviewers

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/11d95e168d7b

Comment 6

[Vasish Baungally]

Attachment: Bug 1956029 - Limit number of tabs suggested to 10. r?rrando

Original Revision: https://phabricator.services.mozilla.com/D243453

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: The modal is not scrollable if we have overflow for a lot of tabs. This is per spec to limit the number of suggested tabs to 10.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: First turn on the following prefs: browser.ml.enable and browser.tabs.groups.smart.enabled. This enables smart tab grouping. Then open at least 11 tabs with the same url but a number appended at the end (e.g. #11). This will ensure that the tab will be suggested for the suggest flow. Now right click on a tab and click on "Add Tab to Group" and then "Suggest more of my tabs". Only 10 tabs max should be suggested.
• Risk associated with taking this patch: There shouldn't be a risk here, just limiting the number of tabs that are suggested
• Explanation of risk level: We're just limiting the number of tabs for better UX.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/f62d1b06c9c4

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 138.0b3 as well as our latest Nightly build 139.0a1 (2025-04-02)