Closed Bug 1956054 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 51555 - Fix WPT by waiting for scroll to reset

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
138 Branch
Tracking Flags:
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51555 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51555
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

Fix WPT by waiting for scroll to reset

This test's flakiness likely arose from not properly waiting for the
scrollTo(0,0) at the beginning of the second test case. The first test
case changes the scroll position and doesn't reset it so I'd expect
that scrollTo(0, 0) to generate a scrollend event.

We'll see if this improves the Linux history[1] and if it does, we can
remove the Mac12 TestExpectations entry[2].

[1] https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Fcss%2Fcss-scroll-snap%2Finput%2Fsnap-area-overflow-boundary-viewport-covering.tentative.html?q=V%3Abuilder%3DLinux%2520Tests%2520%28dbg%29%281%29+V%3Aos%3DUbuntu-22.04+V%3Atest_suite%3Dheadless_shell_wpt_tests
[2] https://source.chromium.org/chromium/chromium/src/+/42485837cb468cee2373242dc081ed8cf5422d28:third_party/blink/web_tests/TestExpectations;l=9020

Bug: 396564890
Change-Id: I0d6f709a431a6ab8eff87dcc6f0eb6d44165ac79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6377586
Commit-Queue: David Awogbemila \<awogbemila@chromium.org>
Reviewed-by: Mustaq Ahmed \<mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436859}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

FAIL : 1
TIMEOUT: 2

Chrome

OK : 1
PASS : 2

Safari

FAIL : 1
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-scroll-snap/input/snap-area-overflow-boundary-viewport-covering.tentative.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • Keyboard scrolling with vertical snap-area overflow: FAIL (Chrome: PASS, Safari: FAIL)
    • Mouse-wheel scrolling with vertical snap-area overflow: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2df62e5da717 [wpt PR 51555] - Fix WPT by waiting for scroll to reset, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2df62e5da717

Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox138: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.