1956169 - Add "Delete bookmark" to the context menu "Firefox suggest"

Status: RESOLVED DUPLICATE of bug 657543

(Firefox :: Address Bar, enhancement, P3)

Description

[WfJjrdAr]

Attachment: firefox (2025-03-11 10-23-27).png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:137.0) Gecko/20100101 Firefox/137.0

Steps to reproduce:

1. Type in the address bar the text for which at least one bookmark will be suggested.
2. Right-click on the found bookmark.

Actual results:

• Pin to Overflow Menu
• Remove from Toolbar
• Menu Bar
• Bookmarks Toolbar
• Customize Toolbar...

Expected results:

• (…)
• Delete bookmark

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Address Bar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[joel.mozillaosi]

Hi there, new contributor here, I recently worked on an address bar context menu bug. I'm curious if this is in fact a bug. If it is, I'd love to take a crack at it.

Comment 3

[WfJjrdAr]

(In reply to joel.mozillaosi from comment #2)

if this is in fact a bug

No, it is

Type: enhancement

(feature request)

Comment 4

[joel.mozillaosi]

(In reply to WfJjrdAr from comment #0)

Expected results:

• (…)
• Delete bookmark

After poking around a bit this morning, I have a few thoughts. Since the context menu that renders when you right click on any of the other types of search results is the same regardless of result type, it doesn't make that much sense to me as a user to expect the "Delete Bookmark" functionality to display in that context menu when right-clicking a bookmark-type search result in "Firefox Suggest". To me it seems that the intended UX should be similar to removing a search result from history (see screenshot for comparison). Does that track for you WfJjrdAr?

Comment 5

[WfJjrdAr]

My UX prompted me to right-click on the suggested bookmark to delete it. It seemed reasonable and expected to me. And I didn't see the option I expected to see.

Did I think this bookmark should behave the same as a history entry? No, because I understand the difference between these entities.

"Does that track for you" — I didn't understand your question. Sorry, but my English is not as good as I would like it to be.

Comment 6

[joel.mozillaosi]

Attachment: firefox_suggest_history_menu.jpg

Comment 7

[joel.mozillaosi]

(In reply to joel.mozillaosi from comment #4)

To me it seems that the intended UX should be similar to removing a search result from history (see screenshot for comparison). Does that track for you WfJjrdAr?

I forgot to attach the screenshot I mentioned, whoops, Attaching now. My point was that the context menu that appears when right clicking any search result entry is the same for each result, regardless of result type (history, bookmarks, search suggestions, etc). It seems to me that the "Delete Bookmark" command wouldn't appear in the context menu the bug describes but instead be presented in a dedicated menu like the "remove from history" command is presented for history-type search results (see attached screenshot). No worries, by "does that track for you?" I was just asking for your opinion on my thoughts.

Comment 8

[Marco Bonardo [:mak]]

The context menu that is currently visible should not be there. That is a regression, maybe from moving our code to use html popover.
Whether there should be a context menu is something we're investigating.

I think being able to manage bookmarks and top sites from these menus (either context or result menu) would be nice. In this case I'd probably suggest we adapt the string to the number of bookmarks that will be removed, like in the Star panel (otherwise the user may remove one bookmark, and maybe have another one... otherwise without adapted string they may not realize they are removing multiple bookmarks).

Comment 9

[Marco Bonardo [:mak]]

this is in practice a dupe of Bug 657543, since the wrong context menu is tracked by Bug 1957448