Open Bug 1956207 Opened 23 days ago Updated 23 days ago

Make sure tools observer isn't added multiple times

Categories

(Firefox :: Sidebar, task, P2)

Product:
Firefox
Component:
Sidebar
Type:
task

Tracking

()

Status:
ASSIGNED

People

(Reporter: sclements, Assigned: sclements)

References

Details

(Whiteboard: [fidefe-sidebar])

Flagged by mossop during review of bug 1947997, SidebarManager.updateDefaultTools adds an observer for a tool on the sidebar.newTool.migration branch that has a value for visibilityPref (if the value of that pref is not enabled, an observer is added). This could potentially be added multiple times for a tool, so we should add a condition to check if an observer isn't already added. Though we'd need one for each tool that is adding an observer so likely would need to be created dynamically.

You need to log in before you can comment on or make changes to this bug.