195628 - Request code is too mail-happy

Status: RESOLVED WORKSFORME

(Bugzilla :: Attachments & Requests, defect)

Description

[Gervase Markham [:gerv]]

[I can't find a bug on this, having looked through everything in this component.]

The whole request system generates far too much mail. When I attach a patch and
request review, I get:
- A mail saying I attached the patch
- A mail about the review request
- A mail showing that the bug has been changed to request review

If it gets reviewed (or not), I similarly get two mails.

We need to either implement some controls, or rethink how we do review mail.
That third one is particularly useless. Perhaps we should send the review
request to the CC list, and suppress that mail? Or not send that mail to the
people who get the review request?

Bug 183868 is related. We also need to fix the problem with the wrong names
being put in mails - I can't find a bug on this either. And the one about
automatically transferring unfulfilled reviews when you attach a patch which
obsoletes another one. That would reduce the spam.

Gerv

Comment 1

[Tobias Burnus]

In addition: If a new patch is added which obsolates an old one, the requests
need to be cancelled and (usually) transfered to the new attachment. If more
than on requestee is given, this even more increases the emails send, since one
cannot add more than one review request at a time.

Comment 2

[Gervase Markham [:gerv]]

This seems to have improved, at least in my perception. Did we actually make any
changes?

Gerv

Comment 3

[Gervase Markham [:gerv]]

Oops.

Gerv

Comment 4

[Frédéric Buclin]

We made a lot of progress in this area, see among others bug 174039, bug 180652, bug 183868, bug 223420, bug 224148 and bug 251869. Marking WFM.