Closed Bug 1956307 Opened 25 days ago Closed 21 days ago

[wpt-sync] Sync PR 51578 - Fix powerless hue component convert logic

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
138 Branch
Tracking Status
firefox138 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 51578 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51578
Details from upstream follow.

CGQAQ <m.jason.liu@gmail.com> wrote:

Fix powerless hue component convert logic

This CL removes the condition that will make the hue component become
powerless, as the spec[1] did not say we should do it. This will end up
generating better gradients.

[1]https://www.w3.org/TR/css-color-4/#ok-lab:~:text=%3Chue%3E%20components%20are%20the%20most%20common%20components%20to%20become%20powerless%3B%20any%20achromatic%20color%20will%20have%20a%20powerless%20hue%20component.

Bug: 403211340
Change-Id: I0bbbfbee27feb3cf61401c53fc58763c947d4b32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6385055
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Reviewed-by: Aaron Krajeski \<aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1437498}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests

Status Summary

Firefox

PASS: 4

Chrome

FAIL: 4

Safari

PASS: 4

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3d880bffc744 [wpt PR 51578] - Fix powerless hue component convert logic, a=testonly https://hg.mozilla.org/integration/autoland/rev/d423fbf57211 [wpt PR 51578] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 138 Branch
You need to log in before you can comment on or make changes to this bug.