1956381 - Perma [beta] browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | single tracking bug

Status: REOPENED

(Firefox :: Tabbed Browser, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: smolnar [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=500953228&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PrOx8WGPSoGcdV_wkeZJhQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PrOx8WGPSoGcdV_wkeZJhQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | should have recorded the correct source and ID - {"id":"1742941428214-22","source":"tab_group"} deepEqual {"source":"tab_group","id":"1742941428214-22"} - 
[task 2025-03-25T22:23:48.770Z] 22:23:48     INFO - Buffered messages finished
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | A promise chain failed to handle a rejection: can't access property "tabs", group is null - stack: ssi_shouldSaveTabGroup@resource:///modules/sessionstore/SessionStore.sys.mjs:6942:21
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - shouldSaveTabGroup@resource:///modules/sessionstore/SessionStore.sys.mjs:904:33
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - #maybeDisableOrHideSaveButton/<@chrome://browser/content/tabbrowser/tabgroup-menu.js:783:52
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - Rejection date: Tue Mar 25 2025 22:23:48 GMT+0000 (Greenwich Mean Time) - false == true - 
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - Stack trace:
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - resource://testing-common/PromiseTestUtils.sys.mjs:assertNoUncaughtRejections:266
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - chrome://mochikit/content/browser-test.js:handleTask:1198
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1153
[task 2025-03-25T22:23:48.772Z] 22:23:48     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-03-25T22:23:48.773Z] 22:23:48     INFO - Leaving test bound test_tabGroupContextMenu_deleteTabGroup
[task 2025-03-25T22:23:48.774Z] 22:23:48     INFO - Entering test bound test_tabOverflowContextMenu_deleteOpenTabGroup
[task 2025-03-25T22:23:48.774Z] 22:23:48     INFO - set up an open tab group to be deleted
[task 2025-03-25T22:23:48.774Z] 22:23:48     INFO - delete the open tab group
[task 2025-03-25T22:23:48.916Z] 22:23:48     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_tab_groups_telemetry.js | should have recorded one tabgroup.delete event - 1 == 1 -

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:sthompson, since you are the author of the regressor, bug 1938430, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1938430

Comment 3

[Intermittent Failures Robot]

Repository breakdown:

• autoland: 2

Table

	no_variant
macosx1470-64--/opt	1
macosx1470-64--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-03-24&endday=2025-03-30&tree=all

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1938430

Comment 5

[Intermittent Failures Robot]

1 failures were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 1

Table

	no_variant
macosx1470-64--/debug	1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-03-31&endday=2025-04-06&tree=all

Comment 6

[Intermittent Failures Robot]

19 failures were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 18
• mozilla-beta: 1

Table

	no_variant	spi-nw
linux1804-64-tsan-qr--/opt	3
macosx1015-64-qr--/opt		3
macosx1470-64--/opt	7
macosx1470-64--/debug	3
windows11-32-24h2--/debug	3

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-04-07&endday=2025-04-13&tree=all

Comment 7

[DJ (:dwalker) (on PTO until Apr 22)]

Attachment: Bug 1956381 - fix window leak in browser_tab_groups_telemetry.js. r?dao

Comment 8

[Intermittent Failures Robot]

18 failures were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 17
• autoland: 1

Table

	msix	no_variant	swr
linux1804-64-qr--/debug			3
macosx1015-64-qr--/debug		3
macosx1470-64--/opt		1
windows11-32-24h2--/debug		4
windows11-64-24h2--/debug	3	4

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-04-14&endday=2025-04-14&tree=all

Comment 9

[DJ (:dwalker) (on PTO until Apr 22)]

Sandor, is this perma failure happening on 138 beta as well, or only in the 139 simulation? Trying to determine if an uplift is necessary here.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3742b523ca9
fix window leak in browser_tab_groups_telemetry.js. r=dao,tabbrowser-reviewers

Comment 11

[Dianna Smith [:diannaS]]

I see it happen quite often on beta pushes
example

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d3742b523ca9

Comment 13

[Cosmin Sabou [:CosminS]]

Hi, an uplift request would be appreciated, treeherder link with failures on beta. Thanks!

Comment 14

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/aa9d45a731da

Comment 15

[Cosmin Sabou [:CosminS]]

Still failing on beta.

Comment 16

[Dianna Smith [:diannaS]]

backing out since it made no difference in beta

Comment 17

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/cb20f06c6462

Comment 18

[Cosmin Sabou [:CosminS]]

Backed out also from trunk: https://hg.mozilla.org/integration/autoland/rev/fff4b7edc2af1bf7dee7687ebf3e930eb31c8c0f

Comment 19

[Intermittent Failures Robot]

28 failures were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 28

Table

	msix	no_variant	swr
linux1804-64-qr--/debug			9
macosx1015-64-qr--/debug		2
windows11-32-24h2--/debug		5
windows11-64-24h2--/debug	5	7

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-04-15&endday=2025-04-15&tree=all

Comment 20

[Serban Stanca [:SerbanS]]

Backout merged in central: https://hg.mozilla.org/mozilla-central/rev/fff4b7edc2af1bf7dee7687ebf3e930eb31c8c0f

Comment 21

[DJ (:dwalker) (on PTO until Apr 22)]

I've been having trouble reproducing the failure. Here's a beta sim I ran on this patch earlier: https://treeherder.mozilla.org/jobs?repo=try&revision=d23b949f9d0b0a84cddf9907798715622454f432

This is for 139 beta, though. Could this be a problem that's only affecting 138?

Comment 22

[DJ (:dwalker) (on PTO until Apr 22)]

I was able to reproduce this problem on beta 138, but it doesn't seem to affect 139. We've had several uplifts to 138 targeting tab groups telemetry so I suspect there's a fix in 139 that needs to be carried over. I'll investigate.

Comment 23

[Dianna Smith [:diannaS]]

i ran a beta try push here if you want to add tests to it - > https://treeherder.mozilla.org/jobs?repo=try&revision=2c389bfa933bd7c5a0159ba53785604763e1abe7

Comment 24

[Intermittent Failures Robot]

16 failures were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 16

Table

	msix	no_variant	swr
linux1804-64-qr--/debug			4
macosx1015-64-qr--/debug		1
windows11-32-24h2--/debug		4
windows11-64-24h2--/debug	4	3

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-04-16&endday=2025-04-16&tree=all

Comment 25

[Intermittent Failures Robot]

28 failures were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 23
• autoland: 5

Table

	msix	no_variant	spi-nw	swr
linux1804-64-qr--/debug				5
linux1804-64-tsan-qr--/opt		1
macosx1015-64-qr--/debug		5	1
macosx1470-64--/opt		1
macosx1470-64--/debug		1
windows11-32-24h2--/debug		5
windows11-64-24h2--/debug	4	5

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-04-17&endday=2025-04-17&tree=all

Comment 26

[Intermittent Failures Robot]

25 failures were associated with this bug yesterday.

Repository breakdown:

• mozilla-beta: 9
• autoland: 13
• mozilla-central: 2
• try: 1

Table

	msix	no_variant	spi-nw	swr
linux1804-64-qr--/debug				2
macosx1015-64-qr--/debug		11	6
windows11-32-24h2--/debug		2
windows11-64-24h2--/debug	1	2
windows11-64-24h2-ccov--/opt		1

For more details, see:

https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1956381&startday=2025-04-18&endday=2025-04-18&tree=all