1956469 - Extraneous spacing and weird wrapping when replying to some messages, or pasting into compose

Status: RESOLVED WORKSFORME

(Thunderbird :: Message Compose Window, defect, P1)

Description

[Brendan Abolivier [:babolivier]]

Attachment: Screencast From 2025-03-26 10-49-08.mp4

When replying to some emails (not all), I've noticed the composer badly renders the quoted message, by adding some extraneous new lines and wrapping the text in a weird way (see attachment).

I could not reproduce with every message. The ones I've managed to reproduce with are messages sent from Thunderbird with some light formatting applied to them, but I'm not sure what's the exact condition in which this happens.

This seems to only happen in the composer's window; once the message is sent it renders mostly fine in both the Sent folder and the recipient's inbox, with the exception that the spaces in my signature seem to have disappeared (see attachment in second comment).

Regression range: https://hg.mozilla.org/comm-central/pushloghtml?fromchange=fe0e90ea68a048922e491981b70361d27ab66064&tochange=39f7588bf7ac6213d3c70760b911c4346834f185
Matching m-c push: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=56d845cfc63ac5522e029c4b44a00de398bde41a&tochange=86fa024dcccb77d3af1e36a575b31de2abc45679

Based on these two ranges, I'd say bug 1951832 is a likely culprit, although flicking editor.white_space_normalization.blink_compatible to false doesn't seem to change anything, so I'm not entirely sure.

Comment 1

[Brendan Abolivier [:babolivier]]

Attachment: Reply with mangled signature

Comment 2

[Magnus Melin [:mkmelin]]

Indeed this is a pretty obnoxious regression.

Comment 3

[Wayne Mery (:wsmwk)]

This won't be great for beta.

Comment 4

[Wayne Mery (:wsmwk)]

Shocking that this wasn't noticed and reported within a few days of the bad build, on 2025-03-20. (but in my case I hadn't updated in over a week)

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(sickish, maybe slower respose)]

I think that the patch for bug 1955047 should be backed out and fix the tests instead of changing the Thunderbird's behavior.

Comment 7

[Magnus Melin [:mkmelin]]

Right, bug 1955047 is the regressor (and that is needed for bug 1951832)

Comment 8

[Daniel Haupt [:dahaupt]]

I have just upgraded to 138.0b1-1 (Linux, Snap) and noticed this. As a downgrading is not possible, a hotfix would be important as I am unable to send emails with the correct formatting.

Comment 9

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/releases/comm-beta/rev/93a0fd772a27678c40dce278707842f3cb5c0b20 landed after b1-1

Comment 10

[bowhay55]

I have had to start using TB 137.b1 as 138 nightly is now unusable for sending new mail, replying and forwarding - completely messes up the formatting of the original email.

Comment 11

[Toby Pilling [:tobyp]]

Hi Ramona, we backed out the regressor and added a patch to fix our tests. Could you please verify that this is now fixed on the Daily starting 2025-04-05?

Comment 12

[Brendan Abolivier [:babolivier]]

fwiw I've just confirmed that this bug doesn't occur anymore on Daily for me

Comment 13

[Magnus Melin [:mkmelin]]

Backout fixed it. Further work in bug 1958646 and related m-c bug.