1956478 - [Downloads v2] Crash in Downloads due to es_AR string substitution format

Status: RESOLVED FIXED

(Firefox for Android :: Downloads, defect, P1)

Description

[Rahul Sainani [:rsainani]]

Steps to reproduce

0. Switch device locale to es_AR.
1. Open Downloads screen on nightly 138
2. "Select" (Not click) 1 or more items, note: you can select by long pressing any item and then subsequently clicking items when screen is in selection mode.
3. Open the menu in the Top App Bar. Click Remove/Delete.

Note that this works in all other locales.

Expected behavior

Snackbar is displayed and files are removed

Actual behavior

Crash

Device information

• Firefox version: 138.0a1
• Android device model:
• Android OS version:

Any additional information?

Comment 1

[Rahul Sainani [:rsainani]]

Attachment: Bug 1956478 - Fix es-ar download string format crash

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This was fixed upstream and I manually triggered an android-l10n sync to pick up the change on autoland. Hopefully that'll green things up shortly.
https://hg.mozilla.org/integration/autoland/rev/4b5d2efd323db50aa730e5b0b0567d2626f8fc6d

We'll also avoid pushing the affected nightly builds to the Play Store to avoid shipping this crash to affected users.

Comment 3

[Rahul Sainani [:rsainani]]

Thank you Ryan! Also repied in Bug 1956387

Comment 4

[Rahul Sainani [:rsainani]]

Closing this as Bug 1956387 has fixed the issue.

Comment 5

[Francesco Lodolo [:flod]]

Changing localized files in mozilla-central doesn't work, you can only fix them upstream in the l10n repository, as they will be replaced in 24h.

See explanation here https://mozilla-l10n.github.io/documentation/products/android-l10n/adding_projects.html#setting-up-the-project-in-source-and-l10n-repositories