1956524 - The Light and Dark themes cannot be selected from the onboarding card

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, defect)

Description

[Mira Lobontiu (Android QA)]

Attachment: Screen_Recording_20250410_164459_Firefox Nightly_1.mp4

Steps to reproduce

1. Open the app with a clean build.
2. Skip to the first onboarding cards - stop at the "Pick a theme" card.
3. Select either of the Light or Dark theme.

Expected behavior

The themes can be selected.

Actual behavior

The Light and Dark themes cannot be selected from the onboarding card.

Device information

Firefox for Android: Nightly 138.0a1
Android devices: Samsung Galaxy Tab S9 Ultra (Android 14), Samsung Galaxy S24 (Android 14), Google Pixel 6 (Android 15)
NOT reproducible on Beta 137.0b10

Comment 1

[Mira Lobontiu (Android QA)]

Last good build was 138.0a1 (Build #2016080466), hg-63a925452bfa+, GV: 138.0a1-20250321040811, AS: 138.20250318050322
First bad build was 138.0a1 (Build #2016080562), hg-3a265fdc9f33+, GV: 138.0a1-20250321163719, AS: 138.20250318050322

Comment 2

[Rebeca Tudor]

Attachment: Bug 1956524 - Fix regression for theme selection card.

The changes added in the patch for bug 1954152 created the regression.
Only with talkback active the options could have been selected.
With this fix the problem is resolved and we keep the same semantics too.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/608228a1a931
Fix regression for theme selection card. r=android-reviewers,tjorjani

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/608228a1a931

Comment 5

[Mira Lobontiu (Android QA)]

Attachment: Screen_Recording_20250327_125001_Firefox Nightly.mp4

The "Choose theme" onboarding is now fixed, but the "Toolbar position" onboarding isn't working. This was not originally reported, but it is an issue now.
Should I file a new issue or is there a different patch for it in this issue?

Tested on today's Firefox for Android Nightly build from 3/27 with Google Pixel 6 (Android 15), and Samsung Galaxy S24 (Android 14).

Comment 6

[Rebeca Tudor]

The fix for "Toolbar position" was added in bug 1954154.