1956541 - macOS crash reporter hits debug assertion with updated toolchain

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

See https://treeherder.mozilla.org/jobs?repo=try&revision=8424a3e9f5cc470caa39d9a4595850db7b374ffa&selectedTaskRun=NJV7g9aeRFi8HZ5qwp_5dQ.0

Part of the issue is that I don't know which of the asserts are we hitting because line number info seems wrong:

toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc:0

I guess it could be either:

• https://searchfox.org/mozilla-central/rev/b22ec3f983078ff98b04cee7dafe4b90342a42bf/toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc#531
• https://searchfox.org/mozilla-central/rev/b22ec3f983078ff98b04cee7dafe4b90342a42bf/toolkit/crashreporter/breakpad-client/mac/handler/minidump_generator.cc#1447-1457

Or maybe something else?

Gabriele, do you know how to best approach this?

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I can try to repro locally later today (no access to a macOS machine right now)

Comment 2

[Emilio Cobos Álvarez (:emilio)]

I don't see anything too related in https://chromium.googlesource.com/breakpad/breakpad/+log either.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Seems like any test like browser/base/content/test/tabcrashed/browser_aboutRestartRequired_basic.js would hit this: https://treeherder.mozilla.org/logviewer?job_id=501046406&repo=try&lineNumber=4906

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1956541 - Remove some gracefully-handled debug assertions from mac minidump generator. r=gsvelto,afranchuk

This unblocks the macOS SDK update.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Actually that seems to help, but causes others: https://treeherder.mozilla.org/jobs?repo=try&revision=1f109fde85aa287afefad8eb21426e9f0a5cb01e&selectedTaskRun=VHLkTHVAQvCKTIYqAu7NZA.0

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1956541 - Use std::vector::data() rather than a potentially OOB access. r=afranchuk,gsvelto

On debug builds with newer libc++, std::vector has bounds checks which
call abort() if you do something like this.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/882dc1e20711
Use std::vector::data() rather than a potentially OOB access. r=afranchuk

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/882dc1e20711