1956616 - Low contrast link color when in Auto mode (Dark)

Status: NEW

(Firefox :: Theme, defect)

Description

[Stefan Smagula]

Attachment: Create Group panel showing the Suggest more tabs link with too little contrast

To configure:
Use Firefox Nightly latest with the light/dark mode set to Automatic.
Set your macOS theme to Dark.
Opt into using the AI tab group functionality (via about:config)
Create a tab group or manage a tab group

Observed
You'll notice that the "Suggest more tabs to group" link has low contrast on the background of the panel (see screenshot).

Expected:
The contrast should be higher.

This may be a design token bug.

Comment 1

[Hanna Jones [:hjones]]

Attachment: button with pref set to false

Hey Stefan - thanks for the report. Taking a look this seems to be due to some styles that come from browser.theme.native-theme pref that's enabled by default in Nightly. The bug :mstriemer linked is relevant - basically that's a pref that's enabled in Nightly only, and it can cause some visual differences between Nightly and release (that bug aims to turn the pref off by default to limit visual discrepancies). If I set browser.theme.native-theme to false I see a teal button, which I think is what we expect (see attached screenshot). Can you confirm that disabling the pref fixes the issue for you locally?

It seems there are also a few changes being made to that button in bug 1956077 that will help it stand out a bit better (looks like a border is getting added).

Comment 2

[Stefan Smagula]

Hi, if I set browser.theme.native-theme to False, then I see a teal (lighter blue, higher contrast) "Suggest..." link.

Comment 3

[Stefan Smagula]

Nick Grato on the Smart Tab Groups team believes that this is a design token issue, so I wasn't sure what "component" to file it under. AFAIK, it is not related to any Tab Groups changes.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.