Closed Bug 1956642 Opened 29 days ago Closed 9 days ago

Expose `mach adb` even if you don't have an android mozconfig set.

Categories

(Firefox Build System :: Mach Core, enhancement)

Product:
Firefox Build System
Component:
Mach Core
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: mgaudet, Unassigned)

References

Details

mach adb is nice, but it turns out that if you have a non-android build set it doesn't work. Which seems surprising to me; would be nice if it worked without that.

What behavior/error are you seeing?

This just worked for me on current central.

My steps:

  1. Bootstrap Android
  2. Ran configure
  3. ./mach adb worked, as expected.
  4. Re-ran bootstrap, selected Firefox for Desktop
  5. Ran configure
  6. ./mach adb still worked, as desired.
ahochheiden@FCVYYF256K mozilla-unified % ./mach adb      
 0:00.24 /Users/ahochheiden/.mozbuild/android-sdk-macosx/platform-tools/adb
Android Debug Bridge version 1.0.41
Version 36.0.0-13206524
Installed as /Users/ahochheiden/.mozbuild/android-sdk-macosx/platform-tools/adb
Running on Darwin 23.6.0 (arm64)

I don't know how to use adb, but mach definitely still found it for me.

The code that ./mach adb executes also looks robust enough to find it as long as it's in a default/expected location, maybe that's the difference here?

Flags: needinfo?(mgaudet)

I was also confused since I was sure I used to have more trouble in the past. It turns out Matt indirectly fixed this in Bug 1946524, as part of Teach android_device.py about non-linux adb paths. In a non-android build the subts path isn't available and we would fall back to checking Android SDK, but that used to fail on Windows / Mac (which is where Matt and I would have each seen this).

Status: NEW → RESOLVED
Closed: 9 days ago
Flags: needinfo?(mgaudet)
Resolution: --- → WORKSFORME

Yeah, WFM too now.

You need to log in before you can comment on or make changes to this bug.