Closed Bug 1956803 Opened 23 days ago Closed 9 days ago

Make relevancy close it's remote settings client

Categories

(Application Services :: Remote Settings, enhancement)

Product:
Application Services
Component:
Remote Settings
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: bdk, Assigned: bdk)

References

Details

(Whiteboard: [disco-])

We have a method that's supposed to close all resources, but it doesn't close the remote settings client. This is an issue because the remote settings client now has an sqlite connection.

We should update the relevancy code to close the client, which requires adding a RemoteSettingsClient::close method.

Once we do that, we should check if we can also fix the workaround that Drew had to add to the suggest code.

Whiteboard: [disco-]
Assignee: nobody → bdeankawamura
Status: NEW → ASSIGNED

Authored by https://github.com/bendk
https://github.com/mozilla/application-services/commit/adcd6fe41d0f958da88da10640e7c30997f450cc
[main] Bug 1956803 - Close Remote Settings clients

Status: ASSIGNED → RESOLVED
Closed: 9 days ago
Flags: qe-verify+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.