1956848 - Enable ML Engine by default

Status: VERIFIED FIXED

(Core :: Machine Learning, task)

Comment 1

[Vasish Baungally]

Attachment: Bug 1956848 - Enable ML Engine by default. r?tarek,calixte,atossou,cgopal,rrando,dimi

Comment 2

[Vasish Baungally]

Every ML related feature has their own pref, so this should be safe to turn on. It's also causing issues where various features are turning it on / off in experiments, affect the results of ongoing ones.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63c8d648bbc1
Enable ML Engine by default. r=tarek,calixte

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/63c8d648bbc1

Comment 5

[Vasish Baungally]

Attachment: Bug 1956848 - Enable ML Engine by default. r?tarek,calixte,atossou,cgopal,rrando,dimi

Original Revision: https://phabricator.services.mozilla.com/D243328

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Link Preview Feature will not work in Firefox 138
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: This feature enables the ML engine. Each ML feature sits behind its own feature flag but unless it is enabled, none of the ML features will work. For the link preview, this pref needs to be on as well as browser.ml.linkPreview.enabled. To test the link preview feature, Alt/Opt + Hover on a link
• Risk associated with taking this patch: There shouldn't be any since all ML features exist behind another feature flag at this time.
• Explanation of risk level: Since this is one switch that allows the ML engine to work, if disabled, no ml feature will work. If enabled, there are other prefs that exist in about:config and / or preferences that need to be turned on, so turning this on shouldn't have an impact
• String changes made/needed: No
• Is Android affected?: no

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Link Preview feature will not work
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Turn on the following prefs: browser.ml.enable and browser.ml.linkPreview.enabled. Open a New Tab and hover over any article. Press "Shift + Alt / Option" and a link preview showing key points should be generated.
• Risk associated with taking this patch: There shouldn't be any.
• Explanation of risk level: This pref is the master switch for the ML engine. Without it, no ML feature will work. However, even if this pref is turned on, all ML features (such as link preview) have their own feature flag in about:config.
• String changes made/needed: No
• Is Android affected?: no

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2dfeb26fcfc

Comment 9

[Ciprian Georgiu, Desktop QA]

I've verified with the latest builds, Beta 138.0b2 (Treeherder build) and Nightly 139.0a1, that the pref browser.ml.enable is set to "true" by default, and that the Link Preview works after enabling the pref browser.ml.linkPreview.enabled. Tested on macOS 14, Windows 11, and Ubuntu 24.04.