1956857 - [wpt-sync] Sync PR 51640 - Support unresolved calc() expressions for steps() timing functions

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 51640 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/51640
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Support unresolved calc() expressions for steps() timing functions

Steps including sign() or sibling-index() that were not possible to
simplify at parse time were causing NOTREACHED() and DCHECK()s to
trigger because we tried to retrieve the integer value at parse time
without checking the CSSValue type for range checking.

Don't do range checking at parse time in such cases, but do range
clamping at computed value time. This is in line with what the
css-values-4 spec says.

Bug: 405422525
Change-Id: Ib620b2bd0eed4d9de646299ae6f510d96f383d90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6400854
Reviewed-by: Daniil Sakhapov \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1438661}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e79ef19c9089228fdd00109e3fb7291c97e02dee

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 22 subtests

Status Summary

Firefox

OK : 2
PASS : 39
FAIL : 5

Chrome

CRASH: 2

Safari

OK : 2
PASS : 41
FAIL : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-transitions/parsing/transition-timing-function-computed.html [wpt.fyi]
  • Property transition-timing-function value 'steps(calc(2 * sibling-index()), jump-none)': FAIL (Safari: FAIL)
  • Property transition-timing-function value 'steps(sibling-index(), jump-none)': FAIL (Safari: FAIL)
  • Property transition-timing-function value 'steps(calc(2 * sign(1em - 1000px)), jump-none)': FAIL (Safari: PASS)
  • Property transition-timing-function value 'steps(calc(2 * sign(1em - 1000px)), start)': FAIL (Safari: PASS)
• /css/css-transitions/parsing/transition-timing-function-valid.html [wpt.fyi]
  • e.style['transition-timing-function'] = "steps(sibling-index(), jump-none)" should set the property value: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28dc4ef6c28a
[wpt PR 51640] - Support unresolved calc() expressions for steps() timing functions, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7b0c112f240b
[wpt PR 51640] - Update wpt metadata, a=testonly

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/28dc4ef6c28a
https://hg.mozilla.org/mozilla-central/rev/7b0c112f240b