Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F"

RESOLVED WORKSFORME

Status

()

--
minor
RESOLVED WORKSFORME
16 years ago
15 years ago

People

(Reporter: km, Assigned: mats)

Tracking

({access, regression})

Trunk
access, regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

16 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030228
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4a) Gecko/20030228

The Edit menu used to have a short cut for "Fill in Form" which was
an "m". Recently, the menu changed and now has the first F underlined.
Since there is an earlier entry "Find in Page" with the first F
also underlined, there is now no keystroke shortcut for "Fill in Form"

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

16 years ago
I can confirm this one.
It's quite annoying, can someone fix it, please? It's been there for quite a
while  and no one seems to care.

Comment 2

16 years ago
Ok, confirming this. Finding out from Netscape UE about whether we can remove
these items altogether since they are duplicated under Tools -> Form Manager ->
Fill in Form and Tools -> Form Manager -> Save Form Info.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: access
OS: Linux → All
Hardware: PC → All

Comment 3

16 years ago
-> Keyboard Navigation
Component: Browser-General → Keyboard: Navigation
(Assignee)

Comment 4

16 years ago
This is a regression from bug 179661.  Piers, are you working on this?
This actually breaks kbd navigation for "Find in This Page".
Keywords: regression
Summary: Bad shortcut for "Fill in Form" → Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F"
(Assignee)

Comment 5

16 years ago
*** Bug 205030 has been marked as a duplicate of this bug. ***
(Assignee)

Comment 6

16 years ago
*** Bug 212052 has been marked as a duplicate of this bug. ***

Comment 7

16 years ago
Mats, sorry, i can't work on this at the moment. Please feel free to take the
bug.
(Assignee)

Comment 8

16 years ago
Created attachment 127364 [details] [diff] [review]
Patch

Change accesskey for "Fill in Form" from 'F' to 'i' to avoid clash in Edit menu

with "Find in This Page"
(Assignee)

Updated

16 years ago
Attachment #127364 - Flags: review?(aaronl)
(Assignee)

Comment 9

16 years ago
Taking this...
Assignee: asa → mats.palmgren
Severity: normal → minor
Summary: Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F" → [FIX] Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F"
Whiteboard: [patch]
(Assignee)

Comment 10

16 years ago
"o" is an alternative that would work also if you prefer that.
The underline under "i" is a bit tiny and hard to see perhaps, but it's
used elsewhere (Page Info) so I guess it's OK.

Comment 11

16 years ago
<kinda offtopic> Isn't the underline for the 'I' in Page Info wider, though,
since it's a capital 'I'? </kinda offtopic>

This affects the entry under the Tools > Form Manager menu as well, right?
(Assignee)

Comment 12

16 years ago
Yes, it will change the "Fill in Form" entry in both menus.

Regarding the width, a capital 'I' has the same width as 'i' (on Linux anyway)
so the underline will be the same too.
Attaching screenshots...
(Assignee)

Comment 13

16 years ago
Created attachment 127392 [details]
Screenshot: Tools->Form Manager menu
(Assignee)

Comment 14

16 years ago
Created attachment 127393 [details]
Screenshot: Edit menu

Comment 15

16 years ago
Comment on attachment 127364 [details] [diff] [review]
Patch

I'm sorry, but we do everything we can to avoid lowercase i or l as accesskeys,
because the underline is so small it's very hard to see.

Our guide for choosing accesskeys is here:
http://www.mozilla.org/projects/ui/accessibility/accesskey.html

Note that we ave some other rules, most of which we picked up from Microsoft's
UI guidelines.
Attachment #127364 - Flags: review?(aaronl) → review-
(Assignee)

Comment 16

16 years ago
Created attachment 127426 [details] [diff] [review]
Patch rev. 2
Attachment #127364 - Attachment is obsolete: true
Attachment #127392 - Attachment is obsolete: true
Attachment #127393 - Attachment is obsolete: true
(Assignee)

Comment 17

16 years ago
Created attachment 127427 [details]
Screenshot: Tools->Form Manager menu
(Assignee)

Comment 18

16 years ago
Created attachment 127428 [details]
Screenshot: Edit menu
(Assignee)

Updated

16 years ago
Attachment #127426 - Flags: review?(aaronl)

Comment 19

16 years ago
Comment on attachment 127426 [details] [diff] [review]
Patch rev. 2

Great. Thanks for doing this.
Attachment #127426 - Flags: review?(aaronl) → review+

Comment 20

16 years ago
*** Bug 213784 has been marked as a duplicate of this bug. ***

Updated

15 years ago
QA Contact: asa

Comment 21

15 years ago
Loaded up the 2003030309 nightly build dated and this bug has been fixed. 
Please mark it as fixed.  Thanks.
(Assignee)

Comment 22

15 years ago
Someone else has already fixed this...

-> WORKSFORME
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → WORKSFORME
Summary: [FIX] Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F" → Edit menu: Bad shortcut for "Fill in Form" - clash with "Find in This Page" both use "F"
Whiteboard: [patch]
You need to log in before you can comment on or make changes to this bug.