1956992 - Fix punctuation in shopping.ftl strings

Status: RESOLVED FIXED

(Firefox Graveyard :: Shopping, defect, P1)

Description

[Francesco Lodolo [:flod]]

This landed a while ago (bug 1916016), and it's almost impossible to catch, but the closing double quote is actually an opening double quote.

shopping-opt-in-integrated-privacy-policy-and-terms-of-use = Review Checker is powered by { -fakespot-brand-full-name }. By selecting “{ shopping-opt-in-integrated-button }“ you agree to { -brand-product-name }’s <a data-l10n-name="privacy_policy">privacy notice</a> and { -fakespot-brand-name }’s <a data-l10n-name="terms_of_use">terms of use.</a>

This is very similar to shopping-callout-not-opted-in-integrated-paragraph2, but that one has the period outside the link, which seems correct.

shopping-callout-not-opted-in-integrated-paragraph2 = By selecting “{ shopping-opt-in-integrated-button }” you agree to { -brand-product-name }’s <a data-l10n-name="privacy_policy">privacy notice</a> and { -fakespot-brand-full-name }’s <a data-l10n-name="terms_of_use">terms of use</a>.

Comment 1

[Francesco Lodolo [:flod]]

Interestingly enough, that string has the same issues of an old one

shopping-onboarding-opt-in-privacy-policy-and-terms-of-use3 = By selecting “{ shopping-onboarding-opt-in-button }“ you agree to { -brand-product-name }’s <a data-l10n-name="privacy_policy">privacy policy</a> and { -fakespot-brand-name }’s <a data-l10n-name="terms_of_use">terms of use.</a>

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1956992 - Review checker: fix quotes and punctuation in term of use stirngs, r=kpatenio!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21cdd98a6828
Review checker: fix quotes and punctuation in term of use stirngs, r=kpatenio,fluent-reviewers

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/21cdd98a6828