1957146 - Attribution is not reported on installation failure

Status: NEW

(Firefox :: Installer, defect, P3)

Description

[Chris DuPuis]

In the stub installer, attribution is only reported is the installation succeeds. This is due to the code to copy the attribution data out of the installer package and into a variable (CopyPostSigningData) used by telemetry here https://searchfox.org/mozilla-central/source/browser/installer/windows/nsis/stub.nsh#1082-1083 is only executed if there are no errors, in this block: https://searchfox.org/mozilla-central/source/browser/installer/windows/nsis/stub.nsh#1057-1067

Change this to always report attribution. This change may require improving the handling of unexpected/error cases in CopyPostSigningData.

Comment 1

[Nick Alexander :nalexander [he/him]]

I support including attribution in as many cases as we can.